handle IMEIs shorter than 15 digits #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkatsuba
reviewed
Sep 6, 2024
| @@ -767,6 +767,13 @@ encode_imsi(IMSI) -> | |||
| << B:64/bits, _/binary>> = << (encode_tbcd(IMSI))/binary, -1:64 >>, | |||
| B. | |||
|
|
|||
| decode_imei(Bin) -> | |||
There was a problem hiding this comment.
This is a duplicate functions which are already defined at lines 763 and 766
There was a problem hiding this comment.
no it's not. Those function are type specific. IMSI and IMEI accidentally use the same encoding, but they are not the same type.
IMEIs are 15 digits and IMEI-SVs are 16 digits (3GPP TS 23.003, clause 6.2), anything else is not a valid IMEI. However, somehow 14 digit values are observed in the wild. Make sure that encoder/decoder handles them, so that higher levels can deal with the values.
RoadRunnr
force-pushed
the
feature/safe-imei-encoding
branch
from
f69e2ff to
32323c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMEIs are 15 digits and IMEI-SVs are 16 digits (3GPP TS 23.003, clause 6.2), anything else is not a valid IMEI. However, somehow 14 digit values are observed in the wild. Make sure that encoder/decoder handles them, so that higher levels can deal with the values.