Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retry logic in UP-seid generation #404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix retry logic in UP-seid generation #404

wants to merge 1 commit into from

Conversation

mitmitmitm
Copy link
Contributor

~0 is usually (i32) 0xffffffff. We should compare up_seid (u64) to (u64) 0xffffffffffffffff instead.

Additionally, adjust loop termination statement such that after exhausting retry limit, retry_cnt == 0 rather than -1, fixing subsequent if statement.

@mitmitmitm
Fix retry logic in UP-seid generation
46b54fe 
~0 is usually (i32) 0xffffffff. We should compare up_seid (u64) to
(u64) 0xffffffffffffffff instead.

Additionally, adjust loop termination statement such that after exhausting
retry limit, retry_cnt == 0 rather than -1, fixing subsequent if statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demo-exe demo-exe Awaiting requested review from demo-exe demo-exe is a code owner

@mogaika mogaika Awaiting requested review from mogaika mogaika is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mitmitmitm