Add hkts #3
Draft
Add hkts #3
+527
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| .orFalse | ||
|
|
||
| private val downloadFlag: Opts[Boolean] = Opts | ||
| private val futureFlag: Opts[Boolean] = Opts |
There was a problem hiding this comment.
let's do with zio too. Instead of future flag use enum
| @@ -30,20 +30,21 @@ object Cli { | |||
| .option[Int]("img_size", help = "Image size 1-1280 (default - 1000)") | |||
| .withDefault(1000) | |||
|
|
|||
| private val inputFile: Opts[String] = | |||
| private val inputFile: Opts[FilePath] = | |||
There was a problem hiding this comment.
support multiple input files. So you can pass a dir instead and then create image per file
| )(implicit | ||
| ME: MonadError[F, Throwable] | ||
| ): F[Unit] = { | ||
| val request = basicRequest.get(uri"${uri.toString}").response(asByteArray) |
There was a problem hiding this comment.
not safe. Exception can be thrown
| @@ -8,47 +8,61 @@ Create an image of a map with given point coordinates. | |||
| You need to have [SBT](https://www.scala-sbt.org/download.html) installed on your machine to run this project. | |||
|
|
|||
| ## Installation | |||
There was a problem hiding this comment.
make readme a little bit more readable
| ```bash | ||
| $ sbt | ||
| sbt: geopoint-visualizer> run plot --swap --download --browser --img_size 1000 --input "inputDir/input.json" | ||
| $ docker run\ |
There was a problem hiding this comment.
you must mention all optional flags and default values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented support for both Futures and IO using HKTs, implemented docker support, implemented ci cd, implemented unit and integration tests