[TBT_22-]add cc timeout messsage #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michal-at-travisci
requested changes
Dec 3, 2024
There was a problem hiding this comment.
I think general exception handler is not a good solution. I'd suggest finding which method is called fromt travis-web in CC check scenario and how to imitate the timeout - and add (if needed) and handle specific error code for this situation; the general exception handler still may be needed, we want a specific error handling for scenario/use case we know may result in travis-api timeout after webhook notification to billing-v2 being missed/received late.
…nto tbt-220-cc-proccessing-timeout-error
…nto tbt-220-cc-proccessing-timeout-error
DominikAlberski
approved these changes
Dec 11, 2024
DominikAlberski
requested changes
Dec 11, 2024
DominikAlberski
approved these changes
Dec 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.