Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included a new recipe to install openjdk8 openj9 build #962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chandrams
Copy link
Contributor

Signed-off-by: Chandrakala [email protected]

What is the problem that this PR is trying to fix?

Included a recipe to install openjdk8 openj9 build available here - https://api.adoptopenjdk.net/

What approach did you choose and why?

How can you make sure the change works as expected?

I have tested my changes here
https://travis-ci.org/chandrams/test-cookbook

Would you like any additional feedback?

@chandrams
Copy link
Contributor Author

Will update the jdk_switcher script and create a PR. Once merged will update the jdk_switcher url in default attributes

@chandrams
Copy link
Contributor Author

michaelklishin/jdk_switcher#15 - Updated the jdk_switcher script, but there is some issue with the tests run, have posted my queries in this PR

@chandrams
Copy link
Contributor Author

Can someone review the changes please.

@chandrams
Copy link
Contributor Author

@bogdanap - Can you please review this or get someone to review this. Thanks.

@michaelklishin
Copy link
Contributor

michaelklishin/jdk_switcher#15 is in.

@chandrams
Copy link
Contributor Author

I have updated the jdk_switcher url link with the commit level. It is more than 2 months since I have opened this PR, Can someone please review the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants