-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Masking entries on the IPs/Hostnames list (curses interface) #269
base: master
Are you sure you want to change the base?
Conversation
…le displaying in curses mode
…masking text for localhost name
Mtr provides an option for skipping the initial part of its output. What about the 'f' option? |
Hi @yvs2014! Thanks for your comment. I completely agree that 'f' command is an option, but in my scenario I almost always want to share the complete trace route (with the response time histogram from the initial part of the output), but without exposing the IPs or hostnames of the local part of the network - I think it's not an uncommon scenario. Regards |
About "how to do this".... from all display modules, they HAVE an IP address (IPV6?) and need a string-to-display. So... if it isn't already like this all those need to call a "convert this to string in current settings". -n specified for numeric output? Then return a string like "8.8.8.8". No -n? "dns.google.com", masked? "--ip masked--". That would mean that after a bit of refactoring, you'd get ALL output modules in one go. So.... This is how I WANT it to be done..... Now I'll start looking at your patch. |
Thanks for your feedback. I’ll work on the change this week ;)
// ******************
Best Regards,
Krzysztof Kielak
… On 24 Sep 2018, at 09:48, Roger Wolff ***@***.***> wrote:
About "how to do this"....
from all display modules, they HAVE an IP address (IPV6?) and need a string-to-display. So... if it isn't already like this all those need to call a "convert this to string in current settings". -n specified for numeric output? Then return a string like "8.8.8.8". No -n? "dns.google.com", masked? "--ip masked--".
That would mean that after a bit of refactoring, you'd get ALL output modules in one go.
So.... This is how I WANT it to be done..... Now I'll start looking at your patch.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
OK. I've looked at your patch. It is specific for curses output. Now the CORE can handle arbitrary masks, but we only support setting them in a few (one at first) basic ways. I understand that YOU are interested in the "curses" variant. But for now I would appreciate it if you could write it in such a way that it will be easy to make it work for other output modules as well. It is acceptable if you only implement "dynamic changing of the mask" in the curses module. It is acceptable if you only modify the curses output module to use the new "convert to string" module. (but preferred if you'd do it for most or all). Can you do it for me like this? |
Hi, |
"module" is a bit a "too big" word. It's going to be more-or-less one function. On the other hand, with the dynamic DNS lookups that we're doing, things may be a bit more complicated than I thought. (The mapping IP addr -> name may change due to new name lookup results coming in, but also by the user changing the mask..... ). |
Hi,
Recently I needed a functionality, to mask initial part of the ip addresses/hostnames from the traceroute information, to hide local part of the network route and get something similar to this output, showing the result of the command:
$ mtr --tcp -P 80 --curses github.com
The output is:
I have added new interactive command '0' (zero), that allows to define how many of existing entries in the host names should be "masked", starting from the top.
Regards,
Chris