Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to make it behave more like stable 0.87 #371

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

totoCZ
Copy link

@totoCZ totoCZ commented Sep 25, 2020

I'm not certain about some things in deconstruct_unix (why (struct ICMPHeader *) (ip + 1) in handle_received_ip4_packet? It should be the same for both sockets.

But I don't have any more time/energy to work on improving it further.

@rewolff
Copy link
Collaborator

rewolff commented Sep 27, 2020

Revert "Change TTL dynamically to adjust for path changes" …
You want to revert some "improvements" that others are working on. You need to provide a better argument than: "I don't like it". For example a case where it did something wrong, so that we can go forward towards "the best of both worlds".

@totoCZ
Copy link
Author

totoCZ commented Sep 27, 2020

Wrong, I don't need to provide anything.

Anyhow, you better read why it's broken.

because it breaks MPLS and hosts start jumping up and down in the interactive display

@rewolff
Copy link
Collaborator

rewolff commented Sep 27, 2020

OK. I don't know how to reproduce the problems you're seeing.

@totoCZ
Copy link
Author

totoCZ commented Sep 27, 2020

Easy, run mtr with -e, ie.

./mtr upc.cz -e

Passes through aorta.net with MPLS, no MPLS labels are displayed.

Run mtr with -u

./mtr upc.cz -u

Unlike versions before that commit multiple hosts on each line start jumping up and down instead of staying at the fixed place making it super hard to read.

@acoul
Copy link

acoul commented Mar 5, 2021

FWIW, I have tested the above patches against mtr-0.94 (with & without the Revert "Change TTL dynamically to adjust for path changes") but issue #232 is still present

@acoul acoul mentioned this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants