-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to make it behave more like stable 0.87 #371
base: master
Are you sure you want to change the base?
Conversation
|
Wrong, I don't need to provide anything. Anyhow, you better read why it's broken.
|
OK. I don't know how to reproduce the problems you're seeing. |
Easy, run mtr with -e, ie. ./mtr upc.cz -e Passes through aorta.net with MPLS, no MPLS labels are displayed. Run mtr with -u ./mtr upc.cz -u Unlike versions before that commit multiple hosts on each line start jumping up and down instead of staying at the fixed place making it super hard to read. |
FWIW, I have tested the above patches against mtr-0.94 (with & without the Revert "Change TTL dynamically to adjust for path changes") but issue #232 is still present |
I'm not certain about some things in deconstruct_unix (why (struct ICMPHeader *) (ip + 1) in handle_received_ip4_packet? It should be the same for both sockets.
But I don't have any more time/energy to work on improving it further.