Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added .nvmrc file #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added .nvmrc file #3

wants to merge 1 commit into from

Conversation

zagortenay333
Copy link

Just a suggestion to use Nvm for node managing; it's amazing! Once installed (it's a one-liner) all you have to do in the dir with the .nvmrc file is this:

$ nvm install

Now you got node and npm installed locally. Since you don't need them installed globally, you don't need sudo for npm anymore either.
There is also a bunch of other cool options.

Only downside is that this bash script is not available for windows, but there are alternatives. If nothing else, people will know exactly what version of node is being used by looking it up in the .nvmrc file.

It's a much tastier way of installing node, and you can also ensure everyone uses the same version of node when contributing and stuff.

@notenociz
Copy link

So I was going to comment with the following but thought not and then thought yes so here are my thoughts:

One concern that I would bring up is whether it is necessary. I see the benefits but are they worth the added size (GitHub does have an overall size limit per user/org though I don't think this is a concern) and also what impacts implementing this will have on workflow (if any).

If these can be addressed, I don't see why not. (Though this might take a while to pull in)

@zagortenay333
Copy link
Author

The file is only 7 bytes; size really doesn't matter this time 😄

@notenociz
Copy link

Right, I guess my comment doesn't matter in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants