Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OperatorInfo decoder when type is partitionedOutputInfo #45

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xuorig
Copy link

@xuorig xuorig commented Jul 4, 2018

When upgrading Presto, we started getting a bunch of:

uninitialized constant Presto::Client::ModelVersions::V0_178::OperatorInfo::PartitionedOutputInfo

It sounds like the class was never added when the model version was added. Regenerating the versions added a bunch of other things to older version. I'm not totally certain if that was manually removed before, so please give this a good 👁 !

Added a test to demonstrate what was failing.

@@ -226,6 +226,22 @@ def decode(hash)
end
end

class << PartitionedOutputInfo =
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big diff, but this is what was missing.

@xuorig
Copy link
Author

xuorig commented Jul 4, 2018

@frsyuki @miniway, if you could give this an 👀 it would be super appreciated 🙏!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant