Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: regenerate parser #3

Closed
wants to merge 1 commit into from

Conversation

Freed-Wu
Copy link

@Freed-Wu Freed-Wu commented May 24, 2024

Fix #2

What is your PYPI user name? I create https://pypi.org/project/tree-sitter-make/ and need to add you 😄

@amaanq
Copy link
Member

amaanq commented May 24, 2024

I'm not sure why you would make the pypi package for a grammar that is not your own, that doesn't make any sense. The contribution to update the bindings is very welcome, but you are not a member of the org nor is this your grammar to begin with, nor are you a maintainer of it. I'd ask you to delete the package and let one of us in control of the publishing here take care of that. Please do not ever publish other people's packages for them, I've had to deal with frustrating experiences stemming from this kind of action before, and it is very annoying to say the least. Once deleted, I can go ahead and get this in + publish this to the appropriate registries

@Freed-Wu
Copy link
Author

I have added you to owners. Before you accepted, I can stop any others to use this name. After accepted, Just remove me is OK.

@amaanq
Copy link
Member

amaanq commented May 24, 2024

Alright - thanks for that, but in general always ask before squatting, it is really frustrating and a no-no, I'll review this now

],
sources: [
"src/parser.c",
// NOTE: if your language has an external scanner, add it here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// NOTE: if your language has an external scanner, add it here.

"sources": [
"bindings/node/binding.cc",
"src/parser.c",
# NOTE: if your language has an external scanner, add it here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# NOTE: if your language has an external scanner, add it here.

includedir=@INCLUDEDIR@

Name: tree-sitter-make
Description: Make grammar for tree-sitter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Description: Make grammar for tree-sitter
Description: Makefile grammar for tree-sitter

might be a little clearer


// #cgo CFLAGS: -std=c11 -fPIC
// #include "../../src/parser.c"
// // NOTE: if your language has an external scanner, add it here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// // NOTE: if your language has an external scanner, add it here.

//! tree-sitter [Parser][], and then use the parser to parse some code:
//!
//! ```
//! let code = r#"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add 1-2 lines of some Make code so that this doc test succeeds

Comment on lines +37 to +43

// Uncomment these to include any queries that this grammar contains

// pub const HIGHLIGHTS_QUERY: &str = include_str!("../../queries/highlights.scm");
// pub const INJECTIONS_QUERY: &str = include_str!("../../queries/injections.scm");
// pub const LOCALS_QUERY: &str = include_str!("../../queries/locals.scm");
// pub const TAGS_QUERY: &str = include_str!("../../queries/tags.scm");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Uncomment these to include any queries that this grammar contains
// pub const HIGHLIGHTS_QUERY: &str = include_str!("../../queries/highlights.scm");
// pub const INJECTIONS_QUERY: &str = include_str!("../../queries/injections.scm");
// pub const LOCALS_QUERY: &str = include_str!("../../queries/locals.scm");
// pub const TAGS_QUERY: &str = include_str!("../../queries/tags.scm");
pub const HIGHLIGHTS_QUERY: &str = include_str!("../../queries/highlights.scm");

package.json Outdated
Comment on lines 8 to 14
"types": "bindings/node",
"homepage": "https://github.com/alemuller/tree-sitter-make#readme",

"bugs": {
"url": "https://github.com/alemuller/tree-sitter-make/issues"
},
"homepage": "https://github.com/alemuller/tree-sitter-make#readme",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update urls here

sources=[
"bindings/python/tree_sitter_make/binding.c",
"src/parser.c",
# NOTE: if your language uses an external scanner, add it here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# NOTE: if your language uses an external scanner, add it here.

@domWalters
Copy link

domWalters commented Dec 16, 2024

@amaanq @Freed-Wu is there anymore work to be done before this can merge?

I'm a user of tree-sitter-make and would really like to be able to install it from PyPi, without having to use:

@amaanq
Copy link
Member

amaanq commented Dec 21, 2024

Superseded by #4

@amaanq amaanq closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Regenerate bindings for latest version of tree-sitter
3 participants