Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Repository Creation form pluggable #8589

Open
wants to merge 3 commits into
base: task/add-web-ui-plugins-infra
Choose a base branch
from

Conversation

itaigilo
Copy link
Contributor

@itaigilo itaigilo commented Feb 3, 2025

Closes #8587.

Change Description

Allow creating plugins for the form of Repository Creation dialog.

@itaigilo itaigilo added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

E2E Test Results - DynamoDB Local - Local Block Adapter

3 passed, 3 failed, 7 skipped

Test failures:
  Setup Page › initial navigation to the base URL should redirect to /setup: common/setup.spec.ts

setup.spec.ts:11:9 initial navigation to the base URL should redirect to /setup

[common-setup] › common/setup.spec.ts:11:9 › Setup Page › initial navigation to the base URL should redirect to /setup

Test timeout of 30000ms exceeded.

Error: page.waitForURL: Test timeout of 30000ms exceeded.
=========================== logs ===========================
waiting for navigation until "load"
  navigated to "http://localhost:8000/repositories"
============================================================

  11 |     test("initial navigation to the base URL should redirect to /setup", async ({ page }) => {
  12 |         await page.goto("/");
> 13 |         await page.waitForURL(/.*\/setup/);
     |                    ^
  14 |     });
  15 |
  16 |     test("username has a defualt value of 'admin'", async ({ page }) => {

    at /home/runner/work/lakeFS/lakeFS/webui/test/e2e/common/setup.spec.ts:13:20

attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
test-results/common-setup-Setup-Page-initial-navigation-to-the-base-URL-should-redirect-to-setup-common-setup/trace.zip
Usage:

    npx playwright show-trace test-results/common-setup-Setup-Page-initial-navigation-to-the-base-URL-should-redirect-to-setup-common-setup/trace.zip

────────────────────────────────────────────────────────────────────────────────────────────────

  Setup Page › successfully submiting the form: common/setup.spec.ts
setup.spec.ts:39:9 successfully submiting the form

  [common-setup] › common/setup.spec.ts:39:9 › Setup Page › successfully submiting the form ────────
Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

Locator: getByText('Welcome to LakeFS!')
Expected: visible
Received: hidden
Call log:
  - expect.toBeVisible with timeout 5000ms
  - waiting for getByText('Welcome to LakeFS!')


  59 |         await loginTab.waitForURL(/.*\/repositories/);
  60 |         const repositoriesPage = new RepositoriesPage(loginTab);
> 61 |         await expect(repositoriesPage.noRepositoriesTitleLocator).toBeVisible();
     |                                                                   ^
  62 |
  63 |         // save local storage state
  64 |         await loginTab.context().storageState({ path: COMMON_STORAGE_STATE_PATH });

    at /home/runner/work/lakeFS/lakeFS/webui/test/e2e/common/setup.spec.ts:61:67

attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
test-results/common-setup-Setup-Page-successfully-submiting-the-form-common-setup/trace.zip
Usage:

    npx playwright show-trace test-results/common-setup-Setup-Page-successfully-submiting-the-form-common-setup/trace.zip

────────────────────────────────────────────────────────────────────────────────────────────────

  Setup Page › after successful setup, navigating to the base URL should redirect to /login: common/setup.spec.ts
setup.spec.ts:69:9 after successful setup, navigating to the base URL should redirect to /login

  [common-setup] › common/setup.spec.ts:69:9 › Setup Page › after successful setup, navigating to the base URL should redirect to /login 
Test timeout of 30000ms exceeded.

Error: page.waitForURL: Test timeout of 30000ms exceeded.
=========================== logs ===========================
waiting for navigation until "load"
  navigated to "http://localhost:8000/repositories"
============================================================

  69 |     test("after successful setup, navigating to the base URL should redirect to /login", async ({ page }) => {
  70 |         await page.goto("/");
> 71 |         await page.waitForURL(/.*\/login/);
     |                    ^
  72 |     });
  73 | });
  74 |

    at /home/runner/work/lakeFS/lakeFS/webui/test/e2e/common/setup.spec.ts:71:20

attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
test-results/common-setup-Setup-Page-after-successful-setup-navigating-to-the-base-URL-should-redirect-to-login-common-setup/trace.zip
Usage:

    npx playwright show-trace test-results/common-setup-Setup-Page-after-successful-setup-navigating-to-the-base-URL-should-redirect-to-login-common-setup/trace.zip

────────────────────────────────────────────────────────────────────────────────────────────────

This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

Copy link

github-actions bot commented Feb 3, 2025

E2E Test Results - Quickstart

3 passed, 3 failed, 5 skipped

Test failures:
  Setup Page › initial navigation to the base URL should redirect to /setup: common/setup.spec.ts

setup.spec.ts:11:9 initial navigation to the base URL should redirect to /setup

[common-setup] › common/setup.spec.ts:11:9 › Setup Page › initial navigation to the base URL should redirect to /setup

Test timeout of 30000ms exceeded.

Error: page.waitForURL: Test timeout of 30000ms exceeded.
=========================== logs ===========================
waiting for navigation until "load"
  navigated to "http://localhost:8000/repositories"
============================================================

  11 |     test("initial navigation to the base URL should redirect to /setup", async ({ page }) => {
  12 |         await page.goto("/");
> 13 |         await page.waitForURL(/.*\/setup/);
     |                    ^
  14 |     });
  15 |
  16 |     test("username has a defualt value of 'admin'", async ({ page }) => {

    at /home/runner/work/lakeFS/lakeFS/webui/test/e2e/common/setup.spec.ts:13:20

attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
test-results/common-setup-Setup-Page-initial-navigation-to-the-base-URL-should-redirect-to-setup-common-setup/trace.zip
Usage:

    npx playwright show-trace test-results/common-setup-Setup-Page-initial-navigation-to-the-base-URL-should-redirect-to-setup-common-setup/trace.zip

────────────────────────────────────────────────────────────────────────────────────────────────

  Setup Page › successfully submiting the form: common/setup.spec.ts
setup.spec.ts:39:9 successfully submiting the form

  [common-setup] › common/setup.spec.ts:39:9 › Setup Page › successfully submiting the form ────────
Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

Locator: getByText('Welcome to LakeFS!')
Expected: visible
Received: hidden
Call log:
  - expect.toBeVisible with timeout 5000ms
  - waiting for getByText('Welcome to LakeFS!')


  59 |         await loginTab.waitForURL(/.*\/repositories/);
  60 |         const repositoriesPage = new RepositoriesPage(loginTab);
> 61 |         await expect(repositoriesPage.noRepositoriesTitleLocator).toBeVisible();
     |                                                                   ^
  62 |
  63 |         // save local storage state
  64 |         await loginTab.context().storageState({ path: COMMON_STORAGE_STATE_PATH });

    at /home/runner/work/lakeFS/lakeFS/webui/test/e2e/common/setup.spec.ts:61:67

attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
test-results/common-setup-Setup-Page-successfully-submiting-the-form-common-setup/trace.zip
Usage:

    npx playwright show-trace test-results/common-setup-Setup-Page-successfully-submiting-the-form-common-setup/trace.zip

────────────────────────────────────────────────────────────────────────────────────────────────

  Setup Page › after successful setup, navigating to the base URL should redirect to /login: common/setup.spec.ts
setup.spec.ts:69:9 after successful setup, navigating to the base URL should redirect to /login

  [common-setup] › common/setup.spec.ts:69:9 › Setup Page › after successful setup, navigating to the base URL should redirect to /login 
Test timeout of 30000ms exceeded.

Error: page.waitForURL: Test timeout of 30000ms exceeded.
=========================== logs ===========================
waiting for navigation until "load"
  navigated to "http://localhost:8000/repositories"
============================================================

  69 |     test("after successful setup, navigating to the base URL should redirect to /login", async ({ page }) => {
  70 |         await page.goto("/");
> 71 |         await page.waitForURL(/.*\/login/);
     |                    ^
  72 |     });
  73 | });
  74 |

    at /home/runner/work/lakeFS/lakeFS/webui/test/e2e/common/setup.spec.ts:71:20

attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
test-results/common-setup-Setup-Page-after-successful-setup-navigating-to-the-base-URL-should-redirect-to-login-common-setup/trace.zip
Usage:

    npx playwright show-trace test-results/common-setup-Setup-Page-after-successful-setup-navigating-to-the-base-URL-should-redirect-to-login-common-setup/trace.zip

────────────────────────────────────────────────────────────────────────────────────────────────

This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant