Accelerate large files download using concurent chunks for lakectl download recursive #8613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kectl fs download recursive The curent `lakectl fs download` supports downloading large files by splitting the files and downloading the content in parallel. This change add the same support to the recursive option with the support to run multiple downloads (of parallel chunks) in parallel. TODO New downloader do not uses sync infrastructure, currently support the same flags: use-presign and parallel downloads. Need to look into progress bar with chunks support. Support no-progress flag as sync does.
nopcoder
added
the
include-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
| if !recursive { | ||
| src := uri.URI{ |
There was a problem hiding this comment.
The description says that we are modifying download with the recursive option. However there appear to be significant changes to the !recursive code branch. What is the nature of these changes?
| @@ -644,10 +642,6 @@ func TestLakectlFsDownload(t *testing.T) { | |||
| require.Contains(t, sanitizedResult, "download ro/ro_1k.2") | |||
| require.Contains(t, sanitizedResult, "download ro/ro_1k.3") | |||
| require.Contains(t, sanitizedResult, "download ro/ro_1k.4") | |||
| require.Contains(t, sanitizedResult, "Download Summary:") | |||
There was a problem hiding this comment.
Doesn't the user still want to see these summaries? Shouldn't they be supported?
| @@ -690,7 +680,6 @@ func TestLakectlFsUpload(t *testing.T) { | |||
| t.Run("single_file_with_recursive", func(t *testing.T) { | |||
| vars["FILE_PATH"] = "data/ro/ro_1k.0" | |||
| RunCmdAndVerifySuccessWithFile(t, Lakectl()+" fs upload --recursive -s files/ro_1k lakefs://"+repoName+"/"+mainBranch+"/"+vars["FILE_PATH"]+" -s files/ro_1k", false, "lakectl_fs_upload", vars) | |||
|
|
|||
There was a problem hiding this comment.
This is ultimately a performance improvement issue. Therefore some benchmarks should be taken to verify not just correctness but comparative performance between new/old implementation in various cases i.e. few small files, lots of small files, few large files, lots of large files...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
lakectl fs downloadsupports downloading large files by splitting the files and downloading the content in parallel.This change add the same support to the recursive option with the support to run multiple downloads (of parallel chunks) in parallel.
Close #8383