Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agent to golang 1.22 #344

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Update agent to golang 1.22 #344

merged 2 commits into from
Oct 1, 2024

Conversation

CDimonaco
Copy link
Member

This PR updates the agent code/building infrastructure to be built with golang 1.22.

@CDimonaco CDimonaco added enhancement New feature or request go Pull requests that update Go code labels Jul 8, 2024
@CDimonaco CDimonaco self-assigned this Jul 8, 2024
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine as long as CI is happy 😄

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad the CI is stopping you but still green light from me

Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢

Copy link
Member

@stefanotorresi stefanotorresi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to update the RPM build requirement here:

BuildRequires: golang(API) = 1.18

@CDimonaco
Copy link
Member Author

we need to update the RPM build requirement here:

BuildRequires: golang(API) = 1.18

@stefanotorresi I updated the build requirement in the previous commits, your link refer to another branch or something similar, if you take a look at the change the buildrequires is set to 1.22

@stefanotorresi
Copy link
Member

uh okay, sorry, I totally didn't see it in the list of changes :D

@stefanotorresi stefanotorresi merged commit e4f9187 into main Oct 1, 2024
11 checks passed
@stefanotorresi stefanotorresi deleted the update_golang_1_22 branch October 1, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Development

Successfully merging this pull request may close these issues.

5 participants