Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image building for arm64 #39

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Docker image building for arm64 #39

merged 1 commit into from
Jun 11, 2024

Conversation

CDimonaco
Copy link
Member

This pr enables building arm64 docker images.

@CDimonaco CDimonaco added the enhancement New feature or request label Jun 11, 2024
@CDimonaco CDimonaco requested a review from arbulu89 June 11, 2024 14:05
@CDimonaco CDimonaco self-assigned this Jun 11, 2024
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Next: deploying trento from a raspberry pi" XD
Thank you man

@@ -26,7 +26,6 @@ jobs:
build-and-push-container-images:
name: Build and push container images
runs-on: ubuntu-22.04
if: github.event_name == 'release' || (github.event_name == 'push' && github.ref_name == 'main')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you will put back this line when you finish testing, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, reverted

@CDimonaco CDimonaco merged commit 286ee23 into main Jun 11, 2024
6 checks passed
@CDimonaco CDimonaco deleted the docker_image_build_arm branch June 11, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants