Allow cleanup(test) to run regardless of deployment #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtorrero
force-pushed
the
always-run-cleanup
branch
from
53c4bd2
to
3ec3bec
Compare
arbulu89
reviewed
Jun 27, 2024
|
@EMaksy @CDimonaco Now this is ready to me reviewed. |
EMaksy
approved these changes
Jul 16, 2024
| @@ -25,9 +25,9 @@ jobs: | |||
|
|
|||
| build-and-push-container-images: | |||
| name: Build and push container images | |||
| runs-on: ubuntu-22.04 | |||
| runs-on: ubuntu-20.04 | |||
There was a problem hiding this comment.
Why the change to a lower version ?
Ubuntu 22 to Ubuntu 20 ?
Something python related?
There was a problem hiding this comment.
CDimonaco
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the cleanup playbook to be executed regardless if the deployment playbook finishes successfully or not.
The playbooks are tested in persistent machines running in the cloud and when a deployment run doesn't finish successfully, the machine is left in an undetermined state that might affect the execution of the next CI run. This PR: