Operations contracts signing with JOSE #84
Conversation
We now create a json encodable elixir map from a proto struct, and then encode as json it to create a signable canonical string encoding. On the verification side, the verified payload is now deserialized and returned as a proto struct.
elixir/lib/contracts.ex
Outdated
| jwk = JOSE.JWK.from_pem(pem_private_key) | ||
| updated_opts = [{:will_be_signed?, true} | opts] | ||
|
|
||
| {:ok, json_encodable_map} = Protobuf.JSON.to_encodable(struct, emit_unpopulated: false) |
There was a problem hiding this comment.
Default for emit_unpopulated is false. Just being explicit here.
deduplication, etc.
There was a problem hiding this comment.
Hey @gagandeepb
I think we need to decide where to send the encoded data.
For me, it looks counterintuitive to send the payload in the signature field and send the data empty.
We should send the payload in data with the correct data type. If the time and expiration time are encapsuled there, we don't need new empty fields (if they are not needed for some validation in the receiver part)
Signed payloads sent as text not in signature attribute field.
This function, decode_json_trento_event, was observed to be not necessary with a bit of refactoring
|
As a consequence of the shared conversation around this topic facilitated by the doc shared elsewhere and this PoC, message signing/verification and the security properties it promises will be re-evaluated at a later point, once a better need for these properties is established. |
PoC/WIP