Add exit codes to the tool #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
approved these changes
Mar 14, 2024
| run::run(endpoint_url, api_key, scenario_label.to_string(), scenarios).await; | ||
| match run::run(endpoint_url, api_key, scenario_label.to_string(), scenarios).await { | ||
| Ok(()) => std::process::exit(exitcode::OK), | ||
| Err(()) => std::process::exit(1) |
There was a problem hiding this comment.
I'm pretty surprised exitcode doesn't have a 1 exit code inside, I know it just wraps value from sysexits.h but it feels a little clumsy 😄
There was a problem hiding this comment.
Yeah man, i don't know why it doesn't include it. I was just to about to remove the complete package usage only for that hehe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add exit codes to the tool. It doesn't change much the logic, except it handles the unauthorized scenario. When one unauthorized error is received, the execution finishes, as the rest will have the same result.
All remaining errors are not treated, and it still returns 0 exit code.
PD: I just was bored, so I thought on doing this. We can entirely ditch if it is so bad hehe