Add rpm server support #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewrite plugin to support rpm server installation
stefanotorresi
commented
Nov 14, 2024
Comment on lines
+161
to
+165
| if rpm -q --quiet trento-server-installer; then | ||
| command -v trento-support &>/dev/null && \ | ||
| trento-support --output stdout --collect all --output stdout | ||
| fi | ||
|
|
There was a problem hiding this comment.
@Thr3d could you please help me with changing this if block to something else? trento-server-installer is now deprecated and its presence as a package shouldn't be used to determine whether or not we have a kubernetes setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports changes performed in https://github.com/Thr3d/supportutils-plugin-trento fork
but: