Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expect enum validation #19

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Add expect enum validation #19

merged 6 commits into from
Feb 29, 2024

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Feb 28, 2024

Add expect_enum expectation type validation.
Having one of expect/expect_same/expect_enum entry in the expectation is tested by json schema: trento-project/wanda#374

PD: I have updated the lock file manually. Running the cargo generate-lockfile is including a loooot of changes, so maybe it will be better to do it in a different PR. I hope it is alright.

@arbulu89 arbulu89 added the enhancement New feature or request label Feb 28, 2024
@dottorblaster
Copy link
Contributor

@arbulu89 it's ok, I'll update the lockfile in another PR if it's too much for you. Just remember that you can rebuild it automatically running cargo build

@arbulu89
Copy link
Contributor Author

@dottorblaster I can perfectly do it in this PR. It doesn't break anything, but it looked to me that it would hide a lot of changes there in this unrelated PR

@arbulu89 arbulu89 force-pushed the add-expect-enum-validation branch 2 times, most recently from 56d89d6 to 350c282 Compare February 29, 2024 12:42
@arbulu89 arbulu89 marked this pull request as ready for review February 29, 2024 12:44
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Any further refactoring is deferrable, no worries!

@arbulu89 arbulu89 merged commit 0a1adc2 into main Feb 29, 2024
1 check passed
@arbulu89 arbulu89 deleted the add-expect-enum-validation branch February 29, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants