-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expect enum validation #19
Conversation
c222ff0
to
cd88cc8
Compare
@arbulu89 it's ok, I'll update the lockfile in another PR if it's too much for you. Just remember that you can rebuild it automatically running |
cd88cc8
to
9cb38b4
Compare
@dottorblaster I can perfectly do it in this PR. It doesn't break anything, but it looked to me that it would hide a lot of changes there in this unrelated PR |
56d89d6
to
350c282
Compare
350c282
to
a450174
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Any further refactoring is deferrable, no worries!
Add
expect_enum
expectation type validation.Having one of
expect/expect_same/expect_enum
entry in the expectation is tested by json schema: trento-project/wanda#374PD: I have updated the lock file manually. Running the
cargo generate-lockfile
is including a loooot of changes, so maybe it will be better to do it in a different PR. I hope it is alright.