Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure_message validation in expect_enum #20

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Fix failure_message validation in expect_enum #20

merged 1 commit into from
Mar 19, 2024

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Mar 19, 2024 •
edited
Loading

Fix failure_message validation in expect_enum.
The validation was complaining in the failure_message validation as I didn't include the expect_enum boolean in the first allow_string_interpolation argument properly.
I should've include this test in the first implementation 😅

@arbulu89 arbulu89 added the bug Something isn't working label Mar 19, 2024
dottorblaster
dottorblaster approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

It happens!

@arbulu89 arbulu89 merged commit 8edfdd8 into main Mar 19, 2024
1 check passed
@arbulu89 arbulu89 deleted the fix-failure-message-validation-expect-enum branch March 19, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottorblaster dottorblaster dottorblaster approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arbulu89 @dottorblaster