Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validation logic #22

Merged
merged 3 commits into from
May 29, 2024
Merged

Refactor validation logic #22

merged 3 commits into from
May 29, 2024

Conversation

jamie-suse
Copy link
Contributor

@jamie-suse jamie-suse commented May 28, 2024

This PR refactors the validate function into smaller, composable validators, hereby referred to as rules.

In the future, these rules will be configurable - allowing users more control over which rules TLint enforces.

@jamie-suse jamie-suse marked this pull request as ready for review May 28, 2024 14:37
@jamie-suse
Copy link
Contributor Author

I want to put emphasis on the naming of the modules. If you prefer another name, let me know.

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this so much, thanks!

@dottorblaster
Copy link
Contributor

(Also, nothing comes to my mind about the naming)

@jamie-suse jamie-suse merged commit 392a306 into main May 29, 2024
1 check passed
@jamie-suse jamie-suse deleted the refactor-validation branch May 29, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants