Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Some errors or potential enhancements in the new cluster settings modal #454

Open
arbulu89 opened this issue Nov 15, 2021 · 3 comments
Open
Labels
bug Something isn't working enhancement Improvement of existing features

Comments

@arbulu89
Copy link
Contributor

arbulu89 commented Nov 15, 2021

I have noticed some issues or inconsistencies in the new cluster settings modal. Some of the comments are just subjective things.
The unique major error is the first item.

  • The group of checks are always shown in different order
  • The width of the modal looks to narrow, it was wider with the previous version at least
  • There is not any closing arrow in the top/right corner
  • The modal doesn't close when we click outside (this was the old behaviour at least)
  • The connection settings collapsable leaves an ugly gray row at the end when it is opened
  • The right side collapse icon (down looking arrow) doesn't change the clicker to a pointer.
  • The group check/uncheck works when you click in the whole row, rather than only the checkable (maybe this is wanted), but the same doesn't happen with the individual checks (marking this strikethrough because it's basically impossible to make it look better right now)
  • When the modal is opened, some quick transitions in the buttons are noticed (colors and sizes of the buttons change)
@arbulu89 arbulu89 added bug Something isn't working enhancement Improvement of existing features labels Nov 15, 2021
@ajaeger
Copy link
Contributor

ajaeger commented Dec 2, 2021

@arbulu89 , the first issue should be fixed with #463. The rest is still open, isn't it?

@arbulu89
Copy link
Contributor Author

arbulu89 commented Dec 2, 2021

@arbulu89 , the first issue should be fixed with #463. The rest is still open, isn't it?

@dottorblaster Worked on this. He might know better the state of the ticket

@dottorblaster
Copy link
Contributor

Thanks @arbulu89, I updated a bit the description going for a strikethrough for the stuff already solved

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement Improvement of existing features
Development

No branches or pull requests

3 participants