This repository has been archived by the owner on May 30, 2022. It is now read-only.
Address HANA cluster settings modal quirks #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dottorblaster
commented
Nov 16, 2021
•
dottorblaster
commented
- the modal closes when we successfully save settings
- now the modal closes when we click on the backdrop
- we have a close button in the upper corner
- pointer turns to a hand when hovering the accordion toggle
- catalog results are now sorted and don't get mixed up every refresh
Especially: * now the modal closes when we click on the backdrop * we have a close button in the upper corner * pointer turns to a hand when hovering the accordion toggle
dottorblaster
requested review from
fabriziosestito,
stefanotorresi,
nelsonkopliku and
arbulu89
fabriziosestito
approved these changes
Nov 16, 2021
|
This addresses a lot of #454 |
arbulu89
reviewed
Nov 16, 2021
| @@ -60,6 +61,11 @@ func ApiChecksCatalogHandler(s services.ChecksService) gin.HandlerFunc { | |||
| g := JSONChecksGroup{Group: group.Group, Checks: group.Checks} | |||
| groupedCatalog = append(groupedCatalog, &g) | |||
| } | |||
|
|
|||
| sort.SliceStable(groupedCatalog, func(i, j int) bool { | |||
There was a problem hiding this comment.
Hey @dottorblaster ,
This is not the correct way of ordering, it is not alphabetical hehe
The order of the groups is based on the name of the checks
This was already codified this way here: https://github.com/trento-project/trento/blob/main/web/models/check.go#L91
The correct fix would be to add the ordering in line 59 like this:
for _, group := range checkGroups.OrderByName() {
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.