-
Notifications
You must be signed in to change notification settings - Fork 26
Add HANA replication state in the Databases list view #338
Add HANA replication state in the Databases list view #338
Conversation
bba8480
to
e59fdb3
Compare
Xabi, my man, it's honest work and it's great, but I must say the UX is... sub-optimal? 😁 Let's get some help here. Maybe we're missing something that could be easy to implement in the page layout. |
Agree. That's why I added that the styling of the data looks bad from the beginning hehe
|
e59fdb3
to
0cd69a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the UX will get better with time :D
Uhm, ok, but what do we intend to do about that? |
I actually prefer to have the discussion now. Postponing it doesn't really do anything more than that, postponing the work hehe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
Should we be adding that much columns?
Badges don't looks the best option, but as we are already using them in the cluster view...
The only thing I would suggest for this specific PR would be choosing a different color for the system replication info, to differentiate from tags.
From a UX standpoint I'd say that I feel there's too many information in that single view.
Not sure though how that could be improved right now. I still do not have enough inputs.
From a more general UX perspective I'd reason around following questions (there could be more)
- What are the goals the users have?
- What helps me as a SAP system admin to detect issues in an ergonomic way?
- Are there some common issues patterns that can be clusteruzed somehow?
- Which are the information needed by a SAP system admin to not only identify the issue, but also know hot to remediate?
For now, what I can think of is:
as a SAP system administrator my need is to know if anything is wrong, not much that things are ok, and have a way remediate asap issues.
So the value that I can see Trento has - at least from a user perspective, and there's probably something I miss - is help detect and eventually remediate asap issues that arise in the system(s)
I think there needs to be discussion around this, at least I would need this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM One little comment, maybe it will be cleaner moving the tag column to the extreme right
Yes, I agree. But I will open a follow up ticket to work on this, as it has it impacts in the SAP systems view as well. Follow up ticket: #356 |
Add HANA system replication mode and status in the Databases list view.
This was requested by @lee-martin , in order to provide an important information in the list view too.
Basically, it adds a new column in the instances tables,
System replication
that has 2 pieces of information:HANA Primary
orHANA Secondary
SOK
orSFAIL
. I have used the cluster nomenclature, as requested by @lee-martin . TheUNKNOWN
,INITIALIZING
andSYNCING
states are omitted (if you want to put something here, just let me know).PD: I don't really like the badge style myself, as it conflicts with the tags, so feel free to suggest a better styling option
PD2: With this implementation the
System replication
column is there even in application type instances (netweaver), with empty data. As we will put the HANA instances in the SAP systems list view, I don't know any other way of putting the infoHere the pics.
SIN
is a single HANA database, so no system replication there:Edit. After talking internally, I have removed the badge style from the system replication mode. Now it looks like this: