Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Checks schema #435

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Update Checks schema #435

merged 2 commits into from
Jul 1, 2024

Conversation

jamie-suse
Copy link
Contributor

@jamie-suse jamie-suse commented May 23, 2024

Updates the Checks schema. The following fields can now take an array as a value:

  • values[n].default
  • values[n].conditions[n].value

The arrays can take types integer or string.

Testing for this will reside in trento-project/tlint#21.

@jamie-suse jamie-suse added the enhancement New feature or request label May 23, 2024
@jamie-suse jamie-suse self-assigned this May 23, 2024
@coveralls
Copy link
Collaborator

coveralls commented May 23, 2024

Coverage Status

coverage: 95.056%. remained the same
when pulling cf5adf2 on update-checks-schema
into 9d8d567 on main.

Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Before merging, try this version with tlint with the check that failed please.
Afterwards, you will need to update tlint itself to update the git submodule as well

@jamie-suse
Copy link
Contributor Author

No worries @arbulu89 I've tested against the previously-failing check which now passes.

Will update the wanda submodule in TLint once this PR is merged 👍

@arbulu89
Copy link
Contributor

@jamie-suse great!
Now to wait a bit until the merge freeze is raised hehe

@jamie-suse jamie-suse merged commit 498c6cc into main Jul 1, 2024
13 checks passed
@jamie-suse jamie-suse deleted the update-checks-schema branch July 1, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants