Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Form Label Alignment Fixes #2959

Merged
merged 7 commits into from
Sep 12, 2024
Merged

General Form Label Alignment Fixes #2959

merged 7 commits into from
Sep 12, 2024

Conversation

jagabomb
Copy link
Contributor

Description

This PR makes the following improvements to the UserForm and ProfileForm components.

  1. Improves the alignment of the Label so that it is more vertically centred with each corresponding input field.
  2. Increases the width of the Label (column) so that slightly longer labels (e.g: Confirm Password and Authenticator App) don't wrap over two lines.

Below are the comparisions:
UserForm
ProfileForm

How was this tested?

Describe the tests that have been added/changed for this new behavior.

  • DONE Visually

@jagabomb jagabomb self-assigned this Sep 10, 2024
janvhs
janvhs approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@janvhs janvhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you

dottorblaster
dottorblaster approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks our god and savior of good UI 😬

@jagabomb jagabomb merged commit 9ae34ab into main Sep 12, 2024
86 checks passed
@jagabomb jagabomb deleted the form-general-alignment-fixes branch September 12, 2024 09:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottorblaster dottorblaster dottorblaster approved these changes

@janvhs janvhs janvhs approved these changes

Assignees

@jagabomb jagabomb

Labels
chore ux
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jagabomb @dottorblaster @janvhs