Skip to content

Commit

Permalink
Merge pull request #83 from plastiv/update_deps
Browse files Browse the repository at this point in the history
Update build dependencies
  • Loading branch information
trevjonez authored May 23, 2021
2 parents e834710 + 253af15 commit a56f0a1
Show file tree
Hide file tree
Showing 9 changed files with 24 additions and 24 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Items listed here may not be exhaustive, if you are seeing issues, check the git
## 1.0.0-rc09
- Formatting and some top-level elements have been moved in commander/composer
- Invoke composer within the project build directory
- Update to Gradle 6.9, AGP 4.2.1, Kotlin 1.4.32, detekt 1.14.2

## 1.0.0-rc08
- Support for ANDROID_SDK_ROOT falling back to ANDROID_HOME and warning when appropriate
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ Composer plugin version | Gradle version | Android plugin version
| 0.13.0 | 5.6 | 3.4.2, 3.5.0-rc01<sup>\*</sup>, 3.6.0-alpha05<sup>\*</sup> |
| 1.0.0-rc07 | 6.4 | 3.6.2, 4.0.0-beta04<sup>\*</sup>, 4.1.0-alpha05<sup>\*</sup> |
| 1.0.0-rc08 | 6.6.1 | 4.0.1, 4.1.0-rc01<sup>\*</sup>, 4.2.0-alpha07<sup>\*</sup> |
| 1.0.0-rc09 | 6.9 | 4.2.1, 7.0.0-beta02<sup>\*</sup>, 7.1.0-alpha01<sup>\*</sup> |

\* Alpha, Beta and RC versions of the android plugin are quickly tested by building against them.
This usually means the published composer plugin will work with those version
Expand Down
6 changes: 3 additions & 3 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ buildscript {
}
dependencies {
val KOTLIN_VERSION: String by rootProject
classpath("org.gradle.kotlin:plugins:1.3.6")
classpath("org.gradle.kotlin:gradle-kotlin-dsl-plugins:1.4.9")
classpath("com.gradle.publish:plugin-publish-plugin:0.11.0")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:$KOTLIN_VERSION")
classpath("com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.4")
Expand All @@ -35,7 +35,7 @@ buildscript {

plugins {
`build-dashboard`
id("io.gitlab.arturbosch.detekt").version("1.12.0").apply(false)
id("io.gitlab.arturbosch.detekt").version("1.14.2").apply(false)
}

allprojects {
Expand All @@ -49,7 +49,7 @@ allprojects {

apply(plugin = "io.gitlab.arturbosch.detekt")
dependencies {
add("detektPlugins", "io.gitlab.arturbosch.detekt:detekt-formatting:1.12.0")
add("detektPlugins", "io.gitlab.arturbosch.detekt:detekt-formatting:1.14.2")
}
}

Expand Down
10 changes: 2 additions & 8 deletions buildSrc/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import io.gitlab.arturbosch.detekt.detekt

plugins {
`kotlin-dsl`
`java-gradle-plugin`
id("io.gitlab.arturbosch.detekt").version("1.12.0")
id("io.gitlab.arturbosch.detekt").version("1.14.2")
}

repositories {
Expand All @@ -21,9 +19,5 @@ gradlePlugin {
}

dependencies {
detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.12.0")
detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.14.2")
}

kotlinDslPluginOptions {
experimentalWarning.set(false)
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,15 @@ import java.io.ByteArrayOutputStream
import java.io.PrintStream
import java.nio.channels.OverlappingFileLockException
import java.util.concurrent.TimeUnit.SECONDS
import kotlin.io.path.ExperimentalPathApi
import kotlin.io.path.createTempFile

@ExperimentalPathApi
class AdbSpec : Spek({

describe("process exit notification output") {

val file = createTempFile().apply {
val file = createTempFile().toFile().apply {
deleteOnExit()
writeText("\ttest \n")
}
Expand Down
10 changes: 7 additions & 3 deletions commander/testSupport/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ android {
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
}
flavorDimensions("version")
variantFilter {
ignore = buildType.name == "release"
}
productFlavors {
create("older") {
dimension = "version"
Expand All @@ -32,3 +29,10 @@ android {
manifest.srcFile(file("AndroidManifest.xml"))
}
}

androidComponents {
val release = selector().withBuildType("release")
beforeVariants(release) { variant ->
variant.enabled = false
}
}
9 changes: 5 additions & 4 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,15 @@ group=com.trevjonez.composer

CGP_VERSION=1.0.0-rc09

AGP_VERSION=4.0.1
#AGP_VERSION=4.1.0-rc01
#AGP_VERSION=4.2.0-alpha07
#AGP_VERSION=4.1.3
AGP_VERSION=4.2.1
#AGP_VERSION=7.0.0-beta02
#AGP_VERSION=7.1.0-alpha01

MIN_SDK=23
COMPILE_SDK=29

KOTLIN_VERSION=1.3.72
KOTLIN_VERSION=1.4.32

org.gradle.caching=true
org.gradle.parallel=true
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-6.9-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
4 changes: 0 additions & 4 deletions plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,3 @@ tasks.named("publishPlugins") {
dependsOn(":commander:android:bintrayUpload")
dependsOn(":composer:bintrayUpload")
}

kotlinDslPluginOptions {
experimentalWarning.set(false)
}

0 comments on commit a56f0a1

Please sign in to comment.