Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't coerce default if callback action #48

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix: Don't coerce default if callback action #48

merged 2 commits into from
Apr 16, 2024

Conversation

trevorld
Copy link
Owner

  • We no longer coerce the type of an option default to match that of its type argument when action = "callback". Thanks husheng (@hs3434) for bug report.

closes #46, closes #47

@trevorld
fix: Don't coerce default if callback action
68b5ccc 
* We no longer coerce the type of an option `default` to match that of
  its `type` argument when `action = "callback"`.
  Thanks husheng (@hs3434) for bug report.

closes #46, closes #47
@trevorld
chore(cran_comments.md): Update test environments and revdepcheck res…
c2a368c 
…ults
@trevorld trevorld merged commit 05f1b86 into master Apr 16, 2024
5 checks passed
@trevorld trevorld deleted the issue47 branch April 16, 2024 00:35
@trevorld trevorld mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If "callback" option with "character" type then logical default converted into a character value
1 participant
@trevorld