Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monero tests binary #3463

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Update monero tests binary #3463

merged 1 commit into from
Feb 5, 2025

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Dec 14, 2023

Fixes #3128. Work in progress, gen_trezor_wallet_passphrase.

@matejcik
Copy link
Contributor

matejcik commented Feb 5, 2025

i'd like to merge this monero update but what's up with that hw "skip_ci" @mmilata ?

@mmilata
Copy link
Member Author

mmilata commented Feb 5, 2025

Perhaps it was not to trigger CI run on GitLab which I think we still had when the PR was opened? I don't think Actions know about skip_ci 🤔

@matejcik matejcik force-pushed the mmilata/update-monero-tests branch from 2958a90 to ca346fd Compare February 5, 2025 14:35
Copy link

github-actions bot commented Feb 5, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@matejcik
Copy link
Contributor

matejcik commented Feb 5, 2025

rebased, force-pushed, and removed that whole commit. (it's still here: 6f97147)
let's see what happens now

@mmilata
Copy link
Member Author

mmilata commented Feb 5, 2025

Clarification, the point of that commit was to trigger a CI run on hardware for testing, while avoiding running the other test jobs. It was meant to be dropped before merging.

@matejcik
Copy link
Contributor

matejcik commented Feb 5, 2025

looks like the Monero update works for normal tests.
could we merge the update regardless of HW status, or is it potentially breaking?

@mmilata
Copy link
Member Author

mmilata commented Feb 5, 2025

Let's merge it.

@mmilata mmilata marked this pull request as ready for review February 5, 2025 15:20
@mmilata mmilata requested a review from matejcik as a code owner February 5, 2025 15:20
@matejcik matejcik merged commit bb5972b into main Feb 5, 2025
94 checks passed
@matejcik matejcik deleted the mmilata/update-monero-tests branch February 5, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

Monero tests can't see WebUSB device
2 participants