refactor(suite): renamed currency to cryptoId

trezor · Dec 19, 2024 · d49bf6d · d49bf6d · adderpositive · Dec 19, 2024
1 parent 3dbdc10
commit d49bf6d
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 25 deletions.
diff --git a/packages/suite/src/hooks/wallet/coinmarket/form/useCoinmarketVerifyAccount.tsx b/packages/suite/src/hooks/wallet/coinmarket/form/useCoinmarketVerifyAccount.tsx
@@ -68,13 +68,13 @@ const getTranslationIds = (
 };
 
 const getSuiteReceiveAccounts = ({
-    currency,
+    cryptoId,
     device,
     symbol,
     isDebug,
     accounts,
 }: CoinmarketGetSuiteReceiveAccountsProps): Account[] | undefined => {
-    if (currency) {
+    if (cryptoId) {
         const unavailableCapabilities = device?.unavailableCapabilities ?? {};
 
         // Is the symbol supported by the suite and the device natively?
@@ -98,7 +98,7 @@ const getSuiteReceiveAccounts = ({
 };
 
 const useCoinmarketVerifyAccount = ({
-    currency,
+    cryptoId,
 }: CoinmarketVerifyAccountProps): CoinmarketVerifyAccountReturnProps => {
     const selectedAccount = useSelector(state => state.wallet.selectedAccount);
     const accounts = useSelector(state => state.wallet.accounts);
@@ -115,22 +115,22 @@ const useCoinmarketVerifyAccount = ({
         CoinmarketVerifyFormAccountOptionProps | undefined
     >();
 
-    const networkId = currency && parseCryptoId(currency).networkId;
-    const symbol = currency && cryptoIdToSymbol(currency);
+    const networkId = cryptoId && parseCryptoId(cryptoId).networkId;
+    const symbol = cryptoId && cryptoIdToSymbol(cryptoId);
     const suiteReceiveAccounts = useMemo(
         () =>
             getSuiteReceiveAccounts({
-                currency,
+                cryptoId,
                 device,
                 symbol,
                 isDebug,
                 accounts,
             }),
-        [accounts, currency, device, isDebug, symbol],
+        [accounts, cryptoId, device, isDebug, symbol],
     );
 
     const { supportedMainnets, supportedTestnets } = useNetworkSupport();
-    const currencyNetwork = currency === undefined ? undefined : cryptoIdToNetwork(currency);
+    const currencyNetwork = cryptoId && cryptoIdToNetwork(cryptoId);
     const findNetworkByType = (network: Network) =>
         network.networkType === currencyNetwork?.networkType;
     const isNetworkSupported =

diff --git a/packages/suite/src/types/coinmarket/coinmarketVerify.ts b/packages/suite/src/types/coinmarket/coinmarketVerify.ts
@@ -21,7 +21,7 @@ export interface CoinmarketVerifyFormAccountOptionProps {
 }
 
 export interface CoinmarketVerifyAccountProps {
-    currency: CryptoId | undefined;
+    cryptoId: CryptoId | undefined;
 }
 
 export interface CoinmarketGetTranslationIdsProps {
@@ -53,7 +53,7 @@ export interface CoinmarketVerifyOptionsItemProps {
 }
 
 export interface CoinmarketGetSuiteReceiveAccountsProps {
-    currency: CryptoId | undefined;
+    cryptoId: CryptoId | undefined;
     device: TrezorDevice | undefined;
     symbol: NetworkSymbol | undefined;
     isDebug: boolean;

diff --git a/...allet/coinmarket/common/CoinmarketSelectedOffer/CoinmarketOfferBuy/CoinmarketOfferBuy.tsx b/...allet/coinmarket/common/CoinmarketSelectedOffer/CoinmarketOfferBuy/CoinmarketOfferBuy.tsx
@@ -14,16 +14,16 @@ export const CoinmarketOfferBuy = ({
     paymentMethod,
     paymentMethodName,
 }: CoinmarketOfferBuyProps) => {
-    const currency = selectedQuote?.receiveCurrency;
-    const coinmarketVerifyAccount = useCoinmarketVerifyAccount({ currency });
+    const cryptoId = selectedQuote?.receiveCurrency;
+    const coinmarketVerifyAccount = useCoinmarketVerifyAccount({ cryptoId });
 
     return (
         <>
             <Card>
-                {currency && (
+                {cryptoId && (
                     <CoinmarketVerify
                         coinmarketVerifyAccount={coinmarketVerifyAccount}
-                        currency={currency}
+                        cryptoId={cryptoId}
                     />
                 )}
             </Card>

diff --git a/...market/common/CoinmarketSelectedOffer/CoinmarketOfferExchange/CoinmarketOfferExchange.tsx b/...market/common/CoinmarketSelectedOffer/CoinmarketOfferExchange/CoinmarketOfferExchange.tsx
@@ -25,18 +25,18 @@ export const CoinmarketOfferExchange = ({
     quoteAmounts,
 }: CoinmarketOfferExchangeProps) => {
     const { exchangeStep } = useCoinmarketFormContext<CoinmarketTradeExchangeType>();
-    const currency = selectedQuote?.receive;
-    const coinmarketVerifyAccount = useCoinmarketVerifyAccount({ currency });
+    const cryptoId = selectedQuote?.receive;
+    const coinmarketVerifyAccount = useCoinmarketVerifyAccount({ cryptoId });
 
     const steps: CoinmarketSelectedOfferStepperItemProps[] = [
         {
             step: 'RECEIVING_ADDRESS',
             translationId: 'TR_EXCHANGE_VERIFY_ADDRESS_STEP',
             isActive: exchangeStep === 'RECEIVING_ADDRESS',
-            component: currency ? (
+            component: cryptoId ? (
                 <CoinmarketVerify
                     coinmarketVerifyAccount={coinmarketVerifyAccount}
-                    currency={currency}
+                    cryptoId={cryptoId}
                 />
             ) : null,
         },

diff --git a/...ws/wallet/coinmarket/common/CoinmarketSelectedOffer/CoinmarketVerify/CoinmarketVerify.tsx b/...ws/wallet/coinmarket/common/CoinmarketSelectedOffer/CoinmarketVerify/CoinmarketVerify.tsx
@@ -26,10 +26,10 @@ import {
 
 interface CoinmarketVerifyProps {
     coinmarketVerifyAccount: CoinmarketVerifyAccountReturnProps;
-    currency: CryptoId;
+    cryptoId: CryptoId;
 }
 
-export const CoinmarketVerify = ({ coinmarketVerifyAccount, currency }: CoinmarketVerifyProps) => {
+export const CoinmarketVerify = ({ coinmarketVerifyAccount, cryptoId }: CoinmarketVerifyProps) => {
     const dispatch = useDispatch();
     const { translationString } = useTranslation();
     const { cryptoIdToCoinSymbol, cryptoIdToNativeCoinSymbol } = useCoinmarketInfo();
@@ -63,8 +63,8 @@ export const CoinmarketVerify = ({ coinmarketVerifyAccount, currency }: Coinmark
     const { ref: networkRef, ...networkField } = form.register('address', {
         required: translationString('TR_EXCHANGE_RECEIVING_ADDRESS_REQUIRED'),
         validate: value => {
-            if (selectedAccountOption?.type === 'NON_SUITE' && currency) {
-                const symbol = cryptoIdToNativeCoinSymbol(currency);
+            if (selectedAccountOption?.type === 'NON_SUITE' && cryptoId) {
+                const symbol = cryptoIdToNativeCoinSymbol(cryptoId);
                 if (value && !addressValidator.validate(value, symbol)) {
                     return translationString('TR_EXCHANGE_RECEIVING_ADDRESS_INVALID');
                 }
@@ -105,11 +105,11 @@ export const CoinmarketVerify = ({ coinmarketVerifyAccount, currency }: Coinmark
             <Paragraph typographyStyle="hint" variant="tertiary">
                 <Translation
                     id="TR_EXCHANGE_RECEIVING_ADDRESS_INFO"
-                    values={{ symbol: cryptoIdToCoinSymbol(currency) }}
+                    values={{ symbol: cryptoIdToCoinSymbol(cryptoId) }}
                 />
             </Paragraph>
             <CoinmarketVerifyOptions
-                receiveNetwork={currency}
+                receiveNetwork={cryptoId}
                 selectedAccountOption={selectedAccountOption}
                 selectAccountOptions={selectAccountOptions}
                 isMenuOpen={isMenuOpen}
@@ -127,7 +127,7 @@ export const CoinmarketVerify = ({ coinmarketVerifyAccount, currency }: Coinmark
                             account={selectedAccountOption?.account}
                             address={address}
                             control={form.control}
-                            receiveSymbol={currency}
+                            receiveSymbol={cryptoId}
                             setValue={form.setValue}
                             label={
                                 <Tooltip