Fix/transport stopped flag #12423
Merged
Fix/transport stopped flag #12423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please rebase 🙏 |
Transport should be stopped before calling Transport.init or in case when Transport.init throws error
szymonlesisz
force-pushed
the
fix/transport-stopped-flag
branch
from
b5cd28b to
f2b4ccc
Compare
szymonlesisz
commented
May 16, 2024
| @@ -93,7 +93,7 @@ export abstract class AbstractTransport extends TypedEmitter<{ | |||
| /** | |||
| * once transport has been stopped, it does not emit any events | |||
| */ | |||
| protected stopped = false; | |||
| protected stopped = true; | |||
There was a problem hiding this comment.
not sure if stopped is the best name, inited ? running?
There was a problem hiding this comment.
I would go for dispose and disposed
mroz22
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #12422