Feat/view only analytics #12424
Merged
Feat/view only analytics #12424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Turn on analytics debug logs by setting EXPO_PUBLIC_IS_ANALYTICS_LOGGER_ENABLED in local .env file
vytick
approved these changes
May 15, 2024
| @@ -11,5 +11,10 @@ export const analytics = new Analytics<SuiteNativeAnalyticsEvent>({ | |||
|
|
|||
| if (isDebugEnv()) { | |||
| // Do not send analytics in development | |||
| analytics.report = () => {}; | |||
| analytics.report = (event: Event) => { | |||
| if (process.env.EXPO_PUBLIC_IS_ANALYTICS_LOGGER_ENABLED) { | |||
There was a problem hiding this comment.
i this condition (and env variable) needed when we only log this while isDebugEnv() ?
There was a problem hiding this comment.
Yes, I think it is still useful - mostly you don't care about analytics during development and you don't want console spammed by it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding analytics for View-only feature and an easy way of debugging analytics reporting.
Related Issue
Resolve #11890
Screenshots: