-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(suite): better Firmware changelog #13354
Conversation
fee5c9c
to
13c012b
Compare
9859412
to
40ef624
Compare
40ef624
to
d3766b6
Compare
First impression: View all + icon is a bit ugly, could you polish it please? 🙏 If possible I would recommend:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -71,9 +70,12 @@ export const FirmwareOffer = ({ customFirmware, targetFirmwareType }: FirmwareOf | |||
const nextVersion = customFirmware | |||
? translationString('TR_CUSTOM_FIRMWARE_VERSION') | |||
: getFwUpdateVersion(originalDevice); | |||
|
|||
const isBtcOnly = originalDevice.firmwareType === FirmwareType.BitcoinOnly; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to take targetFirmwareType
into account to work properly in firmware type switch flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a device here to test with, but this probably won't work correctly during FW installation when switching type. targetFirmwareType
from props is used in case installation hasn't started yet, while targetType
is set when installation begins and used in case targetFirmwareType
prop is not provided. Please test it with e5ebf0e.
6a1479f
to
e240c63
Compare
} | ||
`; | ||
|
||
export const Markdown = (options: Readonly<Options>) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add stories for this component? 🙏
I'd like to keep stories for each DS component. Otherwise it's hard to discover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please please connect related stuff into a single commit 🙏
83fe8dc
to
2c4dde9
Compare
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/9992729947 |
…pport for all changelogs
Resolves: #12783
Resolves: #6987
Change-log now can be written as markdown and lines can be separated for better readability:

Before:

After:
