-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metadata export #15421
metadata export #15421
Conversation
mroz22
commented
Nov 18, 2024
•
edited
Loading
edited
- export raw files to make them transferable between google drive and dropbox https://satoshilabs.slack.com/archives/CKN5C51CJ/p1731686820096629
- BIP-329 style labeling import/export #7406 - possibly reformat data to match standard export/import format
3fae451
to
fe58685
Compare
QA OK
Info:
|
Thanks @bosomt. It was a blind shot by me so I am happy to see it works. The fact that it works makes it low-hanging fruits now. You can only add some toasts to handle the error branches and that's it. It can maybe already be useful for support? Also I was thinking that we maybe could add hidden routes so that support doesn't need to ask users to enable debug. |
fe58685
to
7ddd061
Compare
7ddd061
to
672cbc7
Compare
/rebase |
@mroz22 I have been testing and it works, I just needed rebasing it before otherwise I was getting some errors not sure why. I am having a look if some error handling in the UI is required or something. But from observation and some testing I think this will open at least 2 follow-up tasks:
|
I think I already forced pushed some notifications toasts to handle potential errors. So for purposes of debug mode, it should be ok.
yes, next step.
yes, next step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I really like the idea of extending Suite export/import functionality. It could be very useful for users.
<SectionItem data-testid="@settings/debug/metadata"> | ||
<TextColumn | ||
title="Export" | ||
description="Export labeling files to your computer. You may use this to transfer your labeling files from your Google drive account to your Dropbox account." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This is not translated but I guess for it is fine for debug menu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that should be good for now.