Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata export #15421

Merged
merged 2 commits into from
Dec 30, 2024
Merged

metadata export #15421

merged 2 commits into from
Dec 30, 2024

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Nov 18, 2024

image

@mroz22 mroz22 force-pushed the metadata-export branch 3 times, most recently from 3fae451 to fe58685 Compare November 18, 2024 17:25
@bosomt
Copy link
Contributor

bosomt commented Nov 22, 2024

QA OK

  • tested on 2 independent wallets and devices
  • exported from dropbox by mistake - lost of 429 errors from Dropbox, expected as export from dropbox is not needed/supported
  • exported from Google, archive file was generated
  • imported into Dropbox into Trezor directory
  • After i loaded wallet account/wallet/transactions labels were present

Info:

  • Suite version: desktop 24.12.0 (fe58685)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/24.12.0 Chrome/130.0.6723.91 Electron/33.1.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.3 regular (revision 7f373ae71eca855dd41b4a0fdcc7cadaa13a8281)
  • Transport: BridgeTransport 3.0.0-bundled.24.12.0

@mroz22
Copy link
Contributor Author

mroz22 commented Nov 25, 2024

Thanks @bosomt. It was a blind shot by me so I am happy to see it works. The fact that it works makes it low-hanging fruits now. You can only add some toasts to handle the error branches and that's it.

It can maybe already be useful for support? Also I was thinking that we maybe could add hidden routes so that support doesn't need to ask users to enable debug.

@karliatto
Copy link
Member

/rebase

@karliatto
Copy link
Member

@mroz22 I have been testing and it works, I just needed rebasing it before otherwise I was getting some errors not sure why.

I am having a look if some error handling in the UI is required or something.

But from observation and some testing I think this will open at least 2 follow-up tasks:

@mroz22
Copy link
Contributor Author

mroz22 commented Dec 27, 2024

I am having a look if some error handling in the UI is required or something.

I think I already forced pushed some notifications toasts to handle potential errors. So for purposes of debug mode, it should be ok.

We need to allow importing.

yes, next step.

I think in order to be compatible with https://github.com/bitcoin/bips/blob/master/bip-0329.mediawiki it requires to be in unencrypted .json so it can be import by other wallets as well.

yes, next step.

Copy link
Member

@karliatto karliatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
I really like the idea of extending Suite export/import functionality. It could be very useful for users.

<SectionItem data-testid="@settings/debug/metadata">
<TextColumn
title="Export"
description="Export labeling files to your computer. You may use this to transfer your labeling files from your Google drive account to your Dropbox account."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This is not translated but I guess for it is fine for debug menu

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that should be good for now.

@mroz22 mroz22 marked this pull request as ready for review December 30, 2024 16:18
@mroz22 mroz22 merged commit adb2ff4 into develop Dec 30, 2024
41 checks passed
@mroz22 mroz22 deleted the metadata-export branch December 30, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

3 participants