(WIP) Coins deprecation #15509
Closed
(WIP) Coins deprecation #15509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
|
What will happen if user has remembered accounts for these coins? Maybe a migration to delete them? |
tomasklim
reviewed
Nov 22, 2024
| @@ -269,33 +269,6 @@ export default [ | |||
| subscribe: '', | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
should this be deleted @mroz22?
There was a problem hiding this comment.
I'd rather keep support in the under-suite layers. so no.
tomasklim
reviewed
Nov 22, 2024
| @@ -9,7 +9,6 @@ export const COINS: Record<NetworkSymbol | LegacyNetworkSymbol, string> = { | |||
| bnb: require('../../images/coins/bnb.svg'), | |||
| btc: require('../../images/coins/btc.svg'), | |||
| btg: require('../../images/coins/btg.svg'), | |||
| dash: require('../../images/coins/dash.svg'), | |||
There was a problem hiding this comment.
it should stay here, right? @martykan
There was a problem hiding this comment.
Connect Explorer doesn't need it
mroz22
requested changes
Nov 25, 2024
| @@ -269,33 +269,6 @@ export default [ | |||
| subscribe: '', | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
I'd rather keep support in the under-suite layers. so no.
MiroslavProchazka
force-pushed
the
chore/deprecate-coins
branch
from
e9ad99f to
fa1aee7
Compare
MiroslavProchazka
force-pushed
the
chore/deprecate-coins
branch
from
fa1aee7 to
27ed2f3
Compare
Solved |
MiroslavProchazka
force-pushed
the
chore/deprecate-coins
branch
from
27ed2f3 to
d4dd00d
Compare
|
Closed in favor of #16131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed in favor of #16131
As of February 2025, Trezor Suite will discontinue support for Dash, Bitcoin Gold, DigiByte, Namecoin, and Vertcoin. Users are advised to migrate their funds to alternative wallets to ensure continued access and security. The coins will still be supported on the FW level, so users can still access them using third party wallets.
Proposed Timeline:
I will divide the commits by coin and by environment (desktop/native) to make code review easier.
Please read the following before conducting the code review:Given the points above, I have prepared only basic deprecation that mainly affects NetworksConfig. Everything else (tests, icons, etc.) will remain unchanged until we decide to disable trading options and/or turn off the backends.
Todo:
messages.tsand other mentions in general files?NetworksConfig?This pull request involves the removal of several cryptocurrency networks from the codebase. The changes span multiple files and aim to simplify the configuration and support for the remaining networks.
Removal of cryptocurrency networks:
suite-common/wallet-config/src/networksConfig.ts: Removed configurations fordash,btg,dgb,nmc, andvtcnetworks.suite-common/wallet-config/src/types.ts: Removeddash,btg,dgb,nmc, andvtcfrom theNetworkSymboltype.suite-native/config/src/supportedNetworks.ts: Removeddash,btg,dgb,nmc, andvtcfrom thenetworkSymbolsWhitelistMapand related filtering logic. [1] [2]suite-native/discovery/src/discoveryThunks.ts: Removed batch size configurations fordash,btg,dgb,nmc, andvtc.suite-native/module-accounts-import/src/components/DevXpub.tsx: Removedbtganddgbfrom thedevXpubsconfiguration.suite-native/storage/src/migrations/account/v3.ts: Removeddash,btg,dgb,nmc, andvtcfrom theNetworkSymboltype in migration script.