Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(suite-common): resolve formatAmount TODO in try catch block #16058

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(suite-common): resolve formatAmount TODO in try catch block #16058

wants to merge 1 commit into from
+2 −2

Conversation

izmy
Copy link
Contributor

@izmy izmy commented Dec 19, 2024

Description

formatAmount should not return "-1", it should just throw an error

Related Issue

Resolve #11450

@github-actions GitHub Actions
Copy link

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 21
  • More info

Learn more about 𝝠 Expo Github Action

@tomasklim
Copy link
Member

@izmy can you check unit tests please

tomasklim
tomasklim requested changes Dec 20, 2024
View reviewed changes
Copy link
Member

@tomasklim tomasklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasklim tomasklim tomasklim requested changes

@martykan martykan Awaiting requested review from martykan

@TomasBoda TomasBoda Awaiting requested review from TomasBoda

@enjojoy enjojoy Awaiting requested review from enjojoy

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve formatAmount todo in catch block
2 participants
@izmy @tomasklim