fix: show h instead of apostrophe in taproot xpub to be consistent with firmware #16070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
requested review from
mroz22,
szymonlesisz,
martykan and
marekrjpolak
as code owners
peter-sanderson
force-pushed
the
fix-taproot-xpub-aposthoph
branch
from
42b5a9e to
5561c3b
Compare
There was a problem hiding this comment.
Looks good and works. I'm just slightly against exporting utils directly from Connect's exports. I'd prefer moving the util to some shared package to be imported by both Suite and Connect, I'm just unsure which one. Maybe simply @trezor/utils? It seems a bit too specific to be there, but e.g. parseElectrumUrl urlToOnion are there as well, so 🤷♂️
peter-sanderson
force-pushed
the
fix-taproot-xpub-aposthoph
branch
from
5561c3b to
8087ec2
Compare
peter-sanderson
force-pushed
the
fix-taproot-xpub-aposthoph
branch
from
8087ec2 to
7aa167b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #15277