fix(suite): display symbols #16142
Merged
fix(suite): display symbols #16142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
tomasklim
reviewed
Jan 3, 2025
| networkSymbol: symbol, | ||
| networkCurrencyName: coinSymbol, | ||
| networkSymbol: getNetworkDisplaySymbol(symbol), | ||
| networkCurrencyName: coinSymbol?.toUpperCase(), |
There was a problem hiding this comment.
Because of L2s, there should be on BSC network or on BNB Smart Chain network so use network name or network symbol. Probably name is better?
tomasklim
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix display symbols.
Related Issue
Resolve #16121
Screenshots:
Before
After
TESTsymbol is correct)(this is only testing case,
TESTsymbol is correct)(this is only testing case,
TESTsymbol is correct)