Fix/check seed links #16144
Merged
Fix/check seed links #16144
+91
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
komret
added
bug
3 tasks
| const installationWillChangeFirmwareVendorHeader = | ||
| !!shouldSwitchFirmwareType && | ||
| deviceModelInternal !== undefined && | ||
| ![DeviceModelInternal.T1B1, DeviceModelInternal.T2T1].includes(deviceModelInternal); |
There was a problem hiding this comment.
Maybe we shall add come explanation. I know there is some logic that some models have this change of vendor and other don't but I don't know any details and from the code itself its not obvious to me how this is designed (or reasons why it is the way it is)
peter-sanderson
approved these changes
Jan 3, 2025
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12597403708 |
…ayout, update syntax
trezor-ci
force-pushed
the
fix/check-seed-links
branch
from
48e164d to
bd94a01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in case
deviceWillBeWipedduring firmware update, user is sent to settings to create or check backup, but these settings are not available for firmwares unsupported by Suite. The links should lead right to the create/check backup modals instead. While this is only a problem with unsupported firmware (currently 1.6.1), redirecting right to the create/check backup modal is more convenient than having to go to settings first.Plus some cleanup and fixes along the way, in separate commits. For example, Suite warned users that device will be wiped even though it was not initialized.
TODO:
Related: #16094 - this PR adds Check backup button to
CheckSeedStepfor some cases. I decided to add the button to create or check backup toCheckSeedStepfor every case so that we are consistent.QA:
Some testing scenarios I can think of:
Screenshots
Before:
Notice how clicking on creating a wallet backup in Settings takes you to the empty page. You can click on the Check wallet backup button in the red banner, but:
After:
I don't have a 1.6.1 device so testing with firmware type switch on a TS3.
Without backup:
Screen.Recording.2025-01-03.at.10.22.11.mov
Backed up:
Screen.Recording.2025-01-03.at.10.25.08.mov