Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite-native): unify receive flow navigation for all use cases #16449

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

yanascz
Copy link
Contributor

@yanascz yanascz commented Jan 17, 2025

Follow-up for #16312. Once the receive flow is finished (i.e. receive address confirmed), user is returned to the initial screen upon tapping the close button.

@yanascz yanascz requested a review from a team as a code owner January 17, 2025 15:23
@yanascz yanascz added the mobile Suite Lite issues and PRs label Jan 17, 2025
@yanascz yanascz force-pushed the fix/native/receive-flow-navigation branch 2 times, most recently from 2ac45c4 to 41bd2ba Compare January 17, 2025 15:31
Copy link

github-actions bot commented Jan 17, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 22
  • More info

Learn more about 𝝠 Expo Github Action

@yanascz yanascz force-pushed the fix/native/receive-flow-navigation branch from 41bd2ba to 78facb9 Compare January 17, 2025 15:47
@yanascz yanascz self-assigned this Jan 20, 2025
);
const device = useSelector(selectSelectedDevice);
const hasReceiveButtonRequest = useSelector(hasReceiveAddressButtonRequest);
const ReceiveAccountLoader = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When can I see this loader?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, might be dead code. Will discuss with the team and create a follow-up PR if necessary.

Copy link
Member

@matejkriz matejkriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this works really good including Portfolio Tracker and including enabling new coins and adding new accounts in Receive flow. Great job 👏

@yanascz yanascz merged commit 3636415 into develop Jan 20, 2025
80 checks passed
@yanascz yanascz deleted the fix/native/receive-flow-navigation branch January 20, 2025 11:28
@STew790
Copy link
Contributor

STew790 commented Jan 20, 2025

QA OK
Nice, after confirming the address either in portfolio tracker or with device, I am returned to the homescreen when I click on "X". Much better for testing as well feelsgoodman.jpg.

Info
25.1.2 eb6c201

@STew790 STew790 added the QA OK Issue passed QA without any blocker label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

3 participants