Extract reducers to common package #17090
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
peter-sanderson
added
the
no-project
peter-sanderson
force-pushed
the
bluetooth-common-reducer2
branch
2 times, most recently
from
06d724b to
8bf10a7
Compare
peter-sanderson
force-pushed
the
bluetooth-common-reducer2
branch
from
3049fae to
fe5aa32
Compare
peter-sanderson
commented
Feb 19, 2025
| @@ -35,17 +33,21 @@ type BluetoothConnectProps = { | |||
| uiMode: 'spatial' | 'card'; | |||
| }; | |||
|
|
|||
| const selectAllDevices = prepareSelectAllDevices<BluetoothDevice>(); | |||
There was a problem hiding this comment.
This has to be done to create generic selector with memoized output. Consulted with @Nodonisko
peter-sanderson
force-pushed
the
bluetooth-common-reducer2
branch
from
fe5aa32 to
c0009aa
Compare
peter-sanderson
force-pushed
the
bluetooth-common-reducer2
branch
from
daf8447 to
6d9cf75
Compare
peter-sanderson
force-pushed
the
bluetooth-common-reducer2
branch
from
6d9cf75 to
e1e8026
Compare
Lemonexe
reviewed
Feb 21, 2025
peter-sanderson
force-pushed
the
bluetooth-common-reducer2
branch
from
72fdc6b to
20fcc71
Compare
Lemonexe
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
LGTM. Big amount of work 💪 🚀
I've got some nits and questions (see comments), but I'm not yet very familiar with the topic, so they may be irrelevant.
➡️ feel free to resolve them in a way that you deem suitable.
Also I did not test, because I don't have a BT device, and also because it's not merged into develop. I expect that big QA effort shall be done on feat/rust-bluetooth before merging that.
packages/suite/src/views/settings/SettingsDevice/BluetoothEraseBonds.tsx
Show resolved
Hide resolved
…d state for mobile
…d state for mobile
…d state for mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.