Editor spawning and file writing for sudoedit #1199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(For future reference, security checks are in #1204) |
squell
reviewed
Jul 21, 2025
squell
approved these changes
Jul 21, 2025
Co-authored-by: Marc R. Schoolderman <[email protected]>
squell
added a commit
that referenced
this pull request
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sudoedit functional, though still missing some security checks.
Unlike original sudo, all interactions with the editor process are done from an unprivileged helper process. This way for example replacing the temporary file with a symlink as user is harmless from a security perspective without needing an explicit O_NOFOLLOW. The unprivileged helper process can't be tricked into reading files that the user couldn't already read.