Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openssl-3.0.x #1370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Openssl-3.0.x #1370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/database/prisma/schema.prisma
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ datasource db {

generator client {
provider = "prisma-client-js"
binaryTargets = ["native", "debian-openssl-1.1.x"]
binaryTargets = ["native", "debian-openssl-3.0.x"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Issue: OpenSSL version mismatch between Prisma schema and Docker configuration

The binaryTargets in schema.prisma now specify "debian-openssl-3.0.x", but the Dockerfile installs OpenSSL without specifying a version. This may result in an older OpenSSL version being installed, leading to compatibility issues with the Prisma client.

Recommended Actions:

  • Update the Dockerfile to specify the OpenSSL version as debian-openssl-3.0.x.
  • Verify that the targeted OpenSSL version is available in the package repository.
  • Test the application to ensure compatibility with OpenSSL 3.0.x.
🔗 Analysis chain

Approved: OpenSSL version update for Prisma client

The change from "debian-openssl-1.1.x" to "debian-openssl-3.0.x" in the binaryTargets array is approved. This update aligns the Prisma client with a newer version of OpenSSL, which likely brings security improvements and new features.

To ensure compatibility, please verify the following:

  1. Confirm that the target deployment environment supports OpenSSL 3.0.x.
  2. Test the application thoroughly to ensure there are no compatibility issues with this OpenSSL version change.
  3. Update any documentation or deployment instructions to reflect this change in OpenSSL version requirement.

Run the following script to check for any OpenSSL-related configurations or dependencies in the project:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for OpenSSL-related configurations and dependencies

echo "Checking for OpenSSL-related files and configurations..."

# Search for OpenSSL-related terms in all files
rg -i "openssl" --type-not prisma

# Check package.json for any OpenSSL-related dependencies
if [ -f package.json ]; then
    echo "Checking package.json for OpenSSL-related dependencies:"
    jq '.dependencies, .devDependencies' package.json | rg -i "openssl"
fi

# Check for Docker files that might specify OpenSSL version
fd Dockerfile | xargs rg -i "openssl"

echo "Check complete. Please review the output for any potential conflicts or necessary updates."

Length of output: 754

Script:

#!/bin/bash
# Extract OpenSSL installation commands from Dockerfiles and determine the installed version

echo "Extracting OpenSSL installation commands from Dockerfiles..."

# Find all Dockerfile paths
dockerfiles=$(fd Dockerfile)

# Iterate over each Dockerfile and extract OpenSSL installation lines
for dockerfile in $dockerfiles; do
    echo "Processing $dockerfile..."
    # Extract lines that install OpenSSL
    install_lines=$(rg -i "apt-get install.*openssl" "$dockerfile")
    echo "$install_lines"
    
    if [[ -n "$install_lines" ]]; then
        # Attempt to determine the OpenSSL version being installed
        # Look for specific version numbers in the installation command
        version=$(echo "$install_lines" | rg -oP "openssl\s+\S+" | awk '{print $2}')
        if [[ -n "$version" ]]; then
            echo "OpenSSL version specified: $version"
        else
            echo "No specific OpenSSL version specified. Default version will be installed."
        fi
    fi
    echo ""
done

echo "OpenSSL version extraction complete. Please review the output to confirm the installed versions."

Length of output: 1448

previewFeatures = ["tracing"]
}

Expand Down