Skip to content

Conversation

ericallam
Copy link
Member

Copy link

changeset-bot bot commented Sep 15, 2025

🦋 Changeset detected

Latest commit: b809ce1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
trigger.dev Patch
d3-chat Patch
references-d3-openai-agents Patch
references-nextjs-realtime Patch
@trigger.dev/build Patch
@trigger.dev/core Patch
@trigger.dev/python Patch
@trigger.dev/react-hooks Patch
@trigger.dev/redis-worker Patch
@trigger.dev/rsc Patch
@trigger.dev/schema-to-json Patch
@trigger.dev/sdk Patch
@trigger.dev/database Patch
@trigger.dev/otlp-importer Patch
@internal/cache Patch
@internal/clickhouse Patch
@internal/redis Patch
@internal/replication Patch
@internal/run-engine Patch
@internal/schedule-engine Patch
@internal/testcontainers Patch
@internal/tracing Patch
@internal/zod-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 15, 2025

Walkthrough

This PR adds MCP-related metadata and a server manifest. It introduces a changeset marking a patch release for the trigger.dev package. The CLI v3 package.json description is updated and a new top-level mcpName field (io.github.triggerdotdev/trigger.dev) is added. A new server.json file defines an MCP server manifest with schema, name, description, repo URL, version 4.0.3, npm package details for trigger.dev, stdio transport, and npx runtime hint using the mcp argument. No runtime code changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description only contains a link to an external blog post and does not follow the repository's required template, omitting the "Closes #" line, the checklist, concrete testing steps, a short changelog entry, and any screenshots or verification details, so reviewers lack the context and validation steps needed. Please update the PR description to match the repository template by adding "Closes #" (or stating none), completing the checklist, describing exact testing steps and results, providing a short changelog summary, and attaching screenshots or logs if helpful; you may keep the external link but also summarize its relevance inline.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "chore(mcp): Add our MCP server to the official MCP registry" is concise, uses a conventional-commit style scope, and accurately reflects the primary changes in this PR (adding server.json, adding mcpName to packages/cli-v3/package.json, and the new changeset), so a reviewer scanning history will understand the intent.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ea-branch-85

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (2)
.changeset/beige-flies-fail.md (1)

5-5: Nit: tighten copy and casing in the changeset summary.

Use consistent casing for “MCP” and add terminal punctuation.

-Add the mcpName property to the CLI package.json to allow publishing our MCP server to the Anthropic MCP registry
+Add the mcpName property to the CLI package.json to allow publishing our MCP server to the Anthropic MCP registry.
server.json (1)

28-30: Optional: list commonly used environment variables for better UX.

If your MCP server can use auth/config (e.g., TRIGGER_API_KEY or similar), documenting them here improves inspector and host UX.

Confirm the schema for environment variable descriptors (name/description/required) and I can add them in a follow-up diff.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f9b83d and b809ce1.

📒 Files selected for processing (3)
  • .changeset/beige-flies-fail.md (1 hunks)
  • packages/cli-v3/package.json (3 hunks)
  • server.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-18T10:07:17.368Z
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-08-18T10:07:17.368Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Import Trigger.dev APIs from "trigger.dev/sdk/v3" when writing tasks or related utilities

Applied to files:

  • packages/cli-v3/package.json
📚 Learning: 2025-08-18T10:07:17.368Z
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-08-18T10:07:17.368Z
Learning: Applies to trigger.config.ts : Provide a valid Trigger.dev configuration using defineConfig with project ref and dirs (e.g., ["./trigger"]; tests/specs auto-excluded)

Applied to files:

  • packages/cli-v3/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
  • GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (3)
packages/cli-v3/package.json (1)

15-15: mcpName addition looks good and matches server name.

"mcpName": "io.github.triggerdotdev/trigger.dev" aligns with server.json’s name.

Please confirm Anthropic’s registry expects this field at the top level of the published npm package (not nested under a subkey).

server.json (2)

18-23: Verify executable resolution with npx (bin name vs package name).

Your package’s bin is “trigger”, not “trigger.dev”. Some runners build commands like npx <package>@<version> <args>, which can fail if they don’t explicitly invoke the bin.

Please confirm the MCP registry runner uses the package’s declared bin automatically or supports specifying the bin/command explicitly. If supported, add it here (e.g., a field to indicate command: "trigger"). If not, we may need to encode the invocation via a different runtime hint.


2-2: Schema URI confirmed — verify package launch metadata (server.json line 2)

  • $schema is the current stable preview: https://static.modelcontextprotocol.io/schemas/2025-07-09/server.schema.json.
  • Ensure top-level fields exist: name, description, status, version, packages[]. Each package should include registry_type (e.g., "npm"), identifier (npm name), and version.
  • For npm stdio servers, include transport:"stdio" (in package metadata/_meta) and a launcher hint: preferred pattern is command:"npx" with args:["-y","<package[@Version]","..."] or an explicit bin/command pointing to the package binary.

@@ -1,7 +1,7 @@
{
"name": "trigger.dev",
"version": "4.0.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Version mismatch with server.json (4.0.2 here vs 4.0.3 in server.json).

If the MCP registry fetches the package immediately after this PR merges, pointing the manifest at 4.0.3 while the published package is 4.0.2 will break installs.

Two safe options:

  • Temporarily set server.json to 4.0.2 and update it to 4.0.3 in the release PR generated by Changesets, or
  • Bump this package.json to 4.0.3 in this PR and publish before submitting the registry entry.

Let me know which route you prefer and I’ll prep the diff.

🤖 Prompt for AI Agents
In packages/cli-v3/package.json around line 3 the version is 4.0.2 but
server.json references 4.0.3, causing a registry manifest/install mismatch;
either (A) change server.json to 4.0.2 in this PR and plan to update it to 4.0.3
in the Changesets-generated release PR, or (B) bump packages/cli-v3/package.json
to 4.0.3 in this PR and publish the package before the registry entry lands;
pick one option and apply the corresponding fix (A: update server.json version
to 4.0.2; B: update package.json version to 4.0.3 and perform the publish step
so the published package matches server.json).

Comment on lines +11 to +18
"version": "4.0.3",
"packages": [
{
"registry_type": "npm",
"registry_base_url": "https://registry.npmjs.org",
"identifier": "trigger.dev",
"version": "4.0.3",
"runtime_hint": "npx",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Align versions to what’s published to npm.

server.json references 4.0.3, while the CLI package.json is 4.0.2. If the registry ingests this now, npx resolution will fail.

Option A (safer now): set both fields to 4.0.2, then bump to 4.0.3 in the release PR.

-  "version": "4.0.3",
+  "version": "4.0.2",
@@
-      "identifier": "trigger.dev",
-      "version": "4.0.3",
+      "identifier": "trigger.dev",
+      "version": "4.0.2",

Option B: keep 4.0.3 but gate merge until 4.0.3 is actually published.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"version": "4.0.3",
"packages": [
{
"registry_type": "npm",
"registry_base_url": "https://registry.npmjs.org",
"identifier": "trigger.dev",
"version": "4.0.3",
"runtime_hint": "npx",
"version": "4.0.2",
"packages": [
{
"registry_type": "npm",
"registry_base_url": "https://registry.npmjs.org",
"identifier": "trigger.dev",
"version": "4.0.2",
"runtime_hint": "npx",
🤖 Prompt for AI Agents
In server.json around lines 11 to 18 the top-level "version" and the package
"version" are set to 4.0.3 while the CLI package.json is still 4.0.2, which will
break npx resolution; change both "version" and the package "version" in
server.json to 4.0.2 to match the published CLI (Option A), and plan a follow-up
release PR to bump both to 4.0.3 once that version is actually published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants