Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1707
Problem description: dragging an element using
QDrag->exec()
crashed the program, because by the time DraggableElement was called, it automatically managed to free itself.Even though the palette has been updated with
Qt::QueuedConnection
, which made it possible to callmousePressEvent
using
drag->exec()
before cleaning the elements, thedrag->exec()
call is not blocked in macOS. As a solution, it was possible to block the event loop fordrag->exec()
, but instead it was decided to stupidly emit to update the palette after the corresponding operations (since cleaning is put aftermousePressEvent
in the event loop).P.S. No problems with memory leaks of
mPaletteElements
andmPaletteItems
were found, they are cleaned whenQTreeWidget::clear()
is called. However, they have problems with hashing.