TriBITS snapshot update 2023-03-29 (#11545) #11746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git' Git describe: Vera4.0-RC1-start-1488-gd9a337d8 At commit: commit 014a1538939b783602d2af6033b2175edfb51a96 Author: Roscoe A. Bartlett <[email protected]> Date: Wed Mar 29 10:41:41 2023 -0600 Summary: Remove unused legacy RELATIVE_PATH code (#63, #560)
bartlettroscoe
added
the
TriBITS
…#11545) I resolved the one-line doc conflict in the file: * cmake/tribits/core/package_arch/TribitsPackageMacros.cmake by going with what is on tribits_github_snapshot.
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
Using Repos:
Pull Request Author: bartlettroscoe |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
Hello @jwillenbring, @sebrowne, @rppawlo, @lucbv, this TriBITS update is needed for pre-installing packages and building downstream packages against this. This TriBITS PR update should be maintaining about perfect backwards compatibility compared to what is already in the Trilinos 'develop' branch. (NOTE: The updated tribits/CHANGLOG.md file is documenting some possible breaks in backward compatibility that have already been merged to Trilinos 'develop' but I failed to document before that.) |
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
@bartlettroscoe I have started reading this but it will take a bit of time go through everything especially since I am not CMake/TriBits expert. |
@lucbv, these changes have already been reviewed in the TriBITS GitHub repo (see TriBITSPub/TriBITS#560). This PR should just be a rubber stamp approval. (It make no sense to do detailed reviews of a snapshot commit.) |
sebrowne
reviewed
Mar 30, 2023
|
Someone needs to approve the PR to allow this to merge 👍 |
sebrowne
approved these changes
Mar 30, 2023
8 tasks
@sebrowne, like every TriBITS change as part of this process, if there a problems, people will report them and they will be fixed quickly or if that can't be done quickly, the changes will be backed out and fixed offline. |
bartlettroscoe
added
AT: AUTOMERGE
lucbv
added a commit
to lucbv/kokkos-kernels
that referenced
this pull request
Mar 30, 2023
See Trilinos PR #11746 trilinos/Trilinos#11746
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ sebrowne lucbv ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 11746: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11545 and implements use case 3 from TriBITSPub/TriBITS#63.