Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Add ability to use explicit configure cachefile #12291

Merged
merged 11 commits into from
Oct 3, 2023
Merged

Framework: Add ability to use explicit configure cachefile #12291

merged 11 commits into from
Oct 3, 2023

Commits on Sep 20, 2023

  1. Add ability to use explicit configure cachefile 

    We need to pass -DTrilinos_CONFIGURE_OPTIONS_FILE=XXX instead of -C XXX
sometimes.  Decided to do it for any GCC build.

User Support Ticket(s) or Story Referenced:
trilinos#12024
    @sebrowne
    sebrowne committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f77cb79 View commit details
    Browse the repository at this point in the history

  2. Use 'gnu' instead of 'gcc' for trigger condition 

    User Support Ticket(s) or Story Referenced: TRILFRAME-596
    @sebrowne
    sebrowne committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1046a86 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Remove quotes from CONFIGURE_OPTIONS_FILE 

    Having these here ends up with them in the value once we enter
configure, which then confuses TriBITS about whether a path is relative
or absolute.  Not sure if this is the best place to remove them, but
it's the easiest.

User Support Ticket(s) or Story Referenced: TRILFRAME-596
    @sebrowne
    sebrowne committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    9b070d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Merge branch 'develop' into use_explicit_cachefiles

    @sebrowne
    sebrowne committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    116e6b8 View commit details
    Browse the repository at this point in the history

  2. Use canonical TriBITS optional dependency disablement 

    User Support Ticket(s) or Story Referenced: TRILFRAME-596
    @sebrowne
    sebrowne committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    ca777e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Fix tacho -> basker typo 

    User Support Ticket(s) or Story Referenced: TRILFRAME-596
    @sebrowne
    sebrowne committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    76fb866 View commit details
    Browse the repository at this point in the history

  2. Update macro names to TriBITS canonical 

    User Support Ticket(s) or Story Referenced: TRILFRAME-596
    @sebrowne
    sebrowne committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    eb83908 View commit details
    Browse the repository at this point in the history

  3. Attempt to fix Framework tests 

    User Support Ticket(s) or Story Referenced: TRILFRAME-596
    @sebrowne
    sebrowne committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8a6d332 View commit details
    Browse the repository at this point in the history

  4. Only assert defined vars conditionally 

    Use the value of ${PROJECT_NAME}_ASSERT_DEFINED_DEPENDENCIES to decide
whether or not to throw errors if cross-package enable variables are
undefined. This fixes potential breakages in reduced tarball testing.

User Support Ticket(s) or Story Referenced: TRILFRAME_596
    @sebrowne
    sebrowne committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    f60a244 View commit details
    Browse the repository at this point in the history

  5. Fix help assert formatting 

    User Support Ticket(s) or Story Referenced: TRILFRAME-596
    @sebrowne
    sebrowne committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    2195909 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Fix another test 

    Missing cachefile argument in dummy_args.

User Support Ticket(s) or Story Referenced: TRILFRAME-596
    @sebrowne
    sebrowne committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    eda66f2 View commit details
    Browse the repository at this point in the history