Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve release note for using GNUInstallDirs by default (#12104) #12321

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Improve release note for using GNUInstallDirs by default (#12104) #12321

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6a34b5
Improve release note for using GNUInstallDirs by default (#12104)
bartlettroscoe Sep 23, 2023
063eac0
Mention find_package(Trilinos ...) problem with undefined compilers (…
bartlettroscoe Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions RELEASE_NOTES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,30 @@
CMake

- Change the default for `Trilinos_MUST_FIND_ALL_TPL_LIBS` from `OFF` to
`ON`. It was
turned off by default because it breaks backward compatibility but it also
causes problems for new users and new configurations.
`ON`. It was turned off by default because it breaks backward
compatibility but it also causes problems for new users and new
configurations.

Users that do not want this new behavior can set
`-D Trilinos_MUST_FIND_ALL_TPL_LIBS=OFF`, which is backward compatible.

- Change the default for `Trilinos_USE_GNUINSTALLDIRS` from `OFF` to `ON`,
in the goal to
move Trilinos and TriBITS to modern CMake.
in the goal to move Trilinos and TriBITS to modern CMake.

TriBITS has had the ability to use that paths selected by the standard
CMake module `GNUInstallDirs.cmake` for a long time. But it is turned off
in TriBITS by default and was never turned on in Trilinos, both for the
sake of backward compatibility.

This may break people's existing configurations because it will install
libs in `<prefix>/libs64/` instead of in `<instead>/libs/`. See
libs in `<prefix>/libs64/` instead of in `<prefix>/libs/` on many systems
(e.g. Linux systems). To revert back to using `<prefix>/lib` but still
use `GNUInstallDirs.cmake` for Trilinos, set `-D
CMAKE_INSTALL_LIBDIR:STRING=lib`. NOTE: The setting `-D
Trilinos_USE_GNUINSTALLDIRS=OFF` is deprecated and may be removed in the
future. (I.e. the usage of `GNUInstallDirs.cmake` may be hard-coded in the
future so please try adjusting to the usage of `GNUInstallDirs.cmake` by
Trilinos.) See
https://github.com/trilinos/Trilinos/issues/12104#issuecomment-1691945033
for additional details and instructions.

Expand Down