Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Enable CMAKE_LINK_LIBRARIES_ONLY_TARGETS #12362

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Framework: Enable CMAKE_LINK_LIBRARIES_ONLY_TARGETS #12362

merged 5 commits into from
Oct 6, 2023

Commits on Oct 4, 2023

  1. Turn on LINK_LIBRARIES_ONLY_TARGETS 

    As per trilinos#10081.

User Support Ticket(s) or Story Referenced: TRILFRAME-601
    @sebrowne
    sebrowne committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    1959f20 View commit details
    Browse the repository at this point in the history

  2. Move variable prior to TriBITS call 

    Need to set defaults prior to executing TriBITS, otherwise they will
have no effect.

User Support Ticket(s) or Story Referenced: N/A
    @sebrowne
    sebrowne committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    2ee8d89 View commit details
    Browse the repository at this point in the history

  3. Set value (fix typo) 

    User Support Ticket(s) or Story Referenced: TRILFRAME-601
    @sebrowne
    sebrowne committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    adb1dff View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Properly declare imported 'm' library 

    As per modern CMake recommendations, want to inform CMake that 'm'
('libm') is an imported library outside of the project.  Necessary when
using LINK_LIBRARIES_ONLY_TARGETS to allow CMake to error-check target
dependencies (since this is now a target dependency and not a direct
library dependency).

User Support Ticket(s) or Story Referenced: TRILFRAME-601
    @sebrowne
    sebrowne committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    8c972a7 View commit details
    Browse the repository at this point in the history

  2. Move 'libm' target to packages where it is used 

    Keep the top-level CMakeLists.txt cleaner, and keep the imported
libraries where they are used to make the packages more separable.

User Support Ticket(s) or Story Referenced: TRILFRAME-601
    @sebrowne
    sebrowne committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    81f6955 View commit details
    Browse the repository at this point in the history