Clear password without memset #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngan
commented
Apr 10, 2024
| @@ -55,7 +55,7 @@ export DISTRIBUTION_SLUG | |||
| # and chmod this directory on the host so that the permissions are persisted when the | |||
| # the directory is mounted in the containers. Since the mysql container runs as a non-root | |||
| # user, we need to ensure that the directory is writable by all users. | |||
| mkdir tmp/mysql-certs | |||
| mkdir -p tmp/mysql-certs | |||
There was a problem hiding this comment.
Making this change because it was erring when I run this script locally multiple times.
|
I talked to @composerinteralia about this at RailsConf and we were unsure why the password is cleared at all. It's still available in Ruby, so why bother clearing it in C? We need the password to stick around since it's needed/used for reconnecting, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103
Closes #106
Instead of using
memset()to clear the password, clear the password byte by byte in a loop. Additionally, we mark thechar*asvolatileto ensure that the compiler does not optimize away the memory access or the clearing operation.